Skip to content

Search saved memory both ways before a deep dive - #740

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908
Sep 17, 2026
Merged

Search saved memory both ways before a deep dive#740
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

The agent checks what it already wrote down before it digs in.

When a question is about setup, safety, or whether some thing exists, it first looks through its saved notes.

It also looks for the flip side of the question: both "X is off" and "X is missing". A note that is already there costs one read.

Review Claim

The learned working-style rules require a two-way memory search before a deep dive.

Review Lane

behavior

Review Unit

corpus-lesson

Safety Invariant

Adds one rule; nothing else changes.

Slice Rationale

One rule and its test. No known prior art is cited.

Non-goals

  • The test pins the rule text only.

Test Plan

Test Plan
  • python3 -m unittest tests.test_check_memory_first_rule: fails before, passes after
  • Every step in .github/workflows/ci.yml ran locally on the full stack with rc=0: run_all_tests.sh, check_no_tracked_local_artifacts, check_hook_test_coverage, check_no_silent_hook_except, check_rules_are_wired, check_skills_three_harnesses, check_ecosystem_boundaries, check_skill_file_refs, check_skill_test_coverage, check_skill_test_debt_no_growth, check_skill_trigger_mechanism, check_dora_baseline, check_no_dated_provenance, check_no_new_comments, ruff check . --select E9,F, shellcheck install.sh

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: rerun ./install.sh so installed copies match
  • Data migration? No

🤖 Generated with Claude Code

This was referenced Sep 17, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@EdbertChan

EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 Keep approved fix-later items in every status update #739
2 Search saved memory both ways before a deep dive #740 👈

@EdbertChan EdbertChan mentioned this pull request Sep 17, 2026
Merged
2 tasks
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch from 530799e to d87909b Compare September 17, 2026 00:49
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch from 6616ba2 to 6de7950 Compare September 17, 2026 00:49
@EdbertChan

EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial 530799e 2026-09-17 00:49 UTC
2 content 530799e → d87909b (raw) 2026-09-17 00:49 UTC
3 rebase d87909b → 839ec4f (rebase only) 2026-09-17 04:23 UTC
4 rebase 839ec4f → 8a9d3d2 (rebase only) 2026-09-17 04:37 UTC
5 rebase 8a9d3d2 → a24045c (rebase only) 2026-09-17 04:55 UTC
6 rebase a24045c → 6e8f18b (rebase only) 2026-09-17 05:11 UTC
7 rebase 6e8f18b → d77dae0 (rebase only) 2026-09-17 05:26 UTC
8 rebase d77dae0 → 683d3f3 (rebase only) 2026-09-17 05:40 UTC
9 rebase 683d3f3 → d95242f (rebase only) 2026-09-17 05:56 UTC

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch from 6de7950 to cf6cf76 Compare September 17, 2026 04:23
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch 2 times, most recently from 839ec4f to 8a9d3d2 Compare September 17, 2026 04:37
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch from cf6cf76 to edebaff Compare September 17, 2026 04:37
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch from 8a9d3d2 to a24045c Compare September 17, 2026 04:55
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch 2 times, most recently from 07a35ef to a956a8a Compare September 17, 2026 05:11
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch from a24045c to 6e8f18b Compare September 17, 2026 05:11
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch from a956a8a to d4318fe Compare September 17, 2026 05:25
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch 2 times, most recently from d77dae0 to 683d3f3 Compare September 17, 2026 05:40
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 branch from d4318fe to 627512e Compare September 17, 2026 05:40
@EdbertChan @claude
Search saved memory both ways before a deep dive
d95242f 
An answer already written down costs one read. Add the learned rule and a
test that pins it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I8831f9085cdb5fe672f820dbe96186ca5dc74b29
@EdbertChan
EdbertChan changed the base branch from stack/EdbertChan/feat/memory-rules-into-catstack/keep-approved-fix-later-items-status-update--fec2cad4 to main September 17, 2026 05:56
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/search-saved-memory-ways-deep-dive--8831f908 branch from 683d3f3 to d95242f Compare September 17, 2026 05:56
@mergify

mergify Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan

EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 53 seconds in the queue, including 7 minutes 25 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@mergify mergify Bot added the queued label Sep 17, 2026
@mergify mergify Bot mentioned this pull request Sep 17, 2026
Closed
6 tasks
@mergify
mergify Bot merged commit 7662a3d into main Sep 17, 2026
7 of 12 checks passed
@mergify mergify Bot removed the queued label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

admin-bypass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EdbertChan