Skip to content

Read a script's whole body before asking to run it - #737

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a
Sep 17, 2026
Merged

Read a script's whole body before asking to run it#737
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

Before asking whether to run a script, the agent reads its whole body and names what it kills, deletes, and restarts.

A header comment or dry-run output states intent; the body is what runs.

Review Claim

The learned working-style rules require reading a script's whole body before a consent question.

Review Lane

behavior

Review Unit

corpus-lesson

Safety Invariant

Adds one rule; nothing else changes.

Slice Rationale

One rule and its test. No known prior art is cited.

Non-goals

  • The test pins the rule text only; it cannot check the judgment call itself.

Test Plan

Test Plan
  • python3 -m unittest tests.test_read_script_before_consent_rule: fails before, passes after
  • Every step in .github/workflows/ci.yml ran locally on the full stack with rc=0: run_all_tests.sh, check_no_tracked_local_artifacts, check_hook_test_coverage, check_no_silent_hook_except, check_rules_are_wired, check_skills_three_harnesses, check_ecosystem_boundaries, check_skill_file_refs, check_skill_test_coverage, check_skill_test_debt_no_growth, check_skill_trigger_mechanism, check_dora_baseline, check_no_dated_provenance, check_no_new_comments, ruff check . --select E9,F, shellcheck install.sh

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: rerun ./install.sh so installed copies match
  • Data migration? No

🤖 Generated with Claude Code

This was referenced Sep 17, 2026
Merged
Merged
Merged
Merged
@EdbertChan

EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 Read a script's whole body before asking to run it #737 👈
2 Reconcile declared intent, code, and result when finishing a merge #738
3 Keep approved fix-later items in every status update #739
4 Search saved memory both ways before a deep dive #740

This was referenced Sep 17, 2026
Merged
Merged
Merged
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339 branch from 1b75246 to b400645 Compare September 17, 2026 04:23
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a branch from 769c372 to 8c9a494 Compare September 17, 2026 04:23
@EdbertChan

EdbertChan commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial 769c372 2026-09-17 04:23 UTC
2 rebase 769c372 → 8c9a494 (rebase only) 2026-09-17 04:23 UTC
3 rebase 8c9a494 → 59d5caa (rebase only) 2026-09-17 04:37 UTC
4 rebase 59d5caa → 79b7575 (rebase only) 2026-09-17 04:55 UTC
5 rebase 79b7575 → 8b6dfda (rebase only) 2026-09-17 05:11 UTC

@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a branch from 8c9a494 to 59d5caa Compare September 17, 2026 04:37
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339 branch 2 times, most recently from 81cc51b to aba9455 Compare September 17, 2026 04:55
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a branch from 59d5caa to 79b7575 Compare September 17, 2026 04:55
@EdbertChan @claude
Read a script's whole body before asking to run it
8b6dfda 
A consent question built from a header or dry-run output can approve
something other than what runs. Add the learned rule and a test that pins
it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: Ifa4a6b3a347be36e9ab1d813a41d2dc53792a901
@EdbertChan
EdbertChan changed the base branch from stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339 to main September 17, 2026 05:11
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/read-script-s-whole-body-asking-run--fa4a6b3a branch from 79b7575 to 8b6dfda Compare September 17, 2026 05:11
@mergify

mergify Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan

EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 42 seconds in the queue, including 7 minutes 19 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@mergify mergify Bot added the queued label Sep 17, 2026
@mergify mergify Bot mentioned this pull request Sep 17, 2026
Closed
6 tasks
@mergify
mergify Bot merged commit d5803c7 into main Sep 17, 2026
5 of 9 checks passed
@mergify mergify Bot removed the queued label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

admin-bypass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EdbertChan