Run list loops under bash, not zsh - #736
Merged
mergify[bot] merged 1 commit intoSep 17, 2026
Merged
mergify[bot] merged 1 commit into
mergify[bot] merged 1 commit into
Conversation
This was referenced Sep 17, 2026
Owner
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Sep 17, 2026
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339
branch
from
September 17, 2026 04:23
1b75246 to
b400645
Compare
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
branch
from
September 17, 2026 04:23
5fc502e to
86d94a8
Compare
Owner
Author
Revision history
|
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
branch
from
September 17, 2026 04:37
86d94a8 to
1e0bb34
Compare
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339
branch
from
September 17, 2026 04:37
b400645 to
81cc51b
Compare
zsh does not split an unquoted variable into words, so a list loop runs once and reports success. Add the rule to the learned working-style rules with a test that runs both shells and pins the rule text. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I2b1e4339a193191560c91d8416cd06a4441283dd
EdbertChan
changed the base branch from
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
to
main
September 17, 2026 04:55
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/run-list-loops-under-bash-zsh--2b1e4339
branch
from
September 17, 2026 04:55
81cc51b to
aba9455
Compare
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 6 minutes 57 seconds in the queue, including 6 minutes 27 seconds running CI. Required conditions to merge
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List loops run under bash, because zsh does not split an unquoted variable into words.
Under zsh, a loop over a list kept in one variable runs just once, with the whole list as a single item, and still exits 0.
So the loop looks done, even though it only ever saw one item.
Review Claim
The learned working-style rules require running list loops under bash and counting failed lookups as unchecked.
Review Lane
behavior
Review Unit
corpus-lesson
Safety Invariant
Adds one rule; the test runs both shells so the rule fails loudly if the shell behavior changes.
Slice Rationale
One rule and its test.
Non-goals
Test Plan
Test Plan
python3 -m unittest tests.test_zsh_loop_rule: rule checks fail before, pass after; the premise checks print zsh1and bash3for the same loopEvery step in
.github/workflows/ci.ymlran locally on the full stack with rc=0:run_all_tests.sh,check_no_tracked_local_artifacts,check_hook_test_coverage,check_no_silent_hook_except,check_rules_are_wired,check_skills_three_harnesses,check_ecosystem_boundaries,check_skill_file_refs,check_skill_test_coverage,check_skill_test_debt_no_growth,check_skill_trigger_mechanism,check_dora_baseline,check_no_dated_provenance,check_no_new_comments,ruff check . --select E9,F,shellcheck install.shzsh keeps an unquoted variable whole; bash splits it:
Revert Plan
Revert Plan
git revert <sha>./install.shso installed copies match🤖 Generated with Claude Code