Skip to content

Classify corpus/CLAUDE.learned.md as a corpus lesson - #733

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/classify-corpus-claude-learned-md-corpus-lesson--b8058de4
Sep 17, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/classify-corpus-claude-learned-md-corpus-lesson--b8058de4

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

A change that adds a shared rule plus the one check that pins it now counts as a single piece of review work.

The rules file the agent loads each session is plain text.

The tool that splits a change into review pieces filed it under docs, going by file type alone.

So any check added beside it landed in a second piece, and a pull request pairing a new rule with its check could never pass as one.

Now that file is grouped with the lesson folder it belongs to, so a check that rides along with it stays in the same piece.

Review Claim

The shared rules file now groups with the lessons, and a check added next to it stays neutral.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

Only the one path rule is added; every other path keeps its unit, and the preflight and the Node PR checker still agree on every tracked path.

Slice Rationale

The rule slices above it each pair a learned rule with its test, and they can only pass as single units once this lands.

Non-goals

  • No change to how corpus/skills/**, docs, or tests are classified.

Test Plan

Test Plan
  • python3 -m unittest engine/skills/make-pr/tests/test_preflight.py: the new classification test fails before the config line and passes after; Ran 33 tests ... OK including the drafter-core parity test (after npm ci)
  • Every step in .github/workflows/ci.yml ran locally on the full stack with rc=0: run_all_tests.sh, check_no_tracked_local_artifacts, check_hook_test_coverage, check_no_silent_hook_except, check_rules_are_wired, check_skills_three_harnesses, check_ecosystem_boundaries, check_skill_file_refs, check_skill_test_coverage, check_skill_test_debt_no_growth, check_skill_trigger_mechanism, check_dora_baseline, check_no_dated_provenance, check_no_new_comments, ruff check . --select E9,F, shellcheck install.sh

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: rerun ./install.sh so installed copies match
  • Data migration? No

🤖 Generated with Claude Code

The learned rules file fell through to the docs-by-extension rule, so a PR
that adds a rule and the test pinning it read as two review units. Class it
with corpus/skills so its tests ride along, and pin that in the preflight
tests.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: Ib8058de42a469d080f0242d1c2394f0e120cfaa0
@EdbertChan

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 Classify corpus/CLAUDE.learned.md as a corpus lesson #733 👈
2 Park abandoned work on a branch or worktree, never with git stash #734
3 Count a background job as the wakeup behind an ETA, and call the time an estimate #735
4 Run list loops under bash, not zsh #736
5 Read a script's whole body before asking to run it #737
6 Never resolve a conflict by taking one side's whole file #738
7 Keep approved fix-later items in every status update #739
8 Search saved memory both ways before a deep dive #740

@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan

Copy link
Copy Markdown
Owner Author

Mergify repair stopped: PR #733 is ready to land, but upper stack PR(s) #736, #738 are open without admin-bypass; a human must decide whether to include them in the admin-bypass landing stack or land them separately.

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue admin-bypass

@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 8 minutes 13 seconds in the queue, including 19 minutes 19 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@mergify mergify Bot added the queued label Sep 17, 2026
@mergify
mergify Bot merged commit 6334d35 into main Sep 17, 2026
5 of 9 checks passed
@mergify mergify Bot removed the queued label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant