Classify corpus/CLAUDE.learned.md as a corpus lesson - #733
Merged
Conversation
The learned rules file fell through to the docs-by-extension rule, so a PR that adds a rule and the test pinning it read as two review units. Class it with corpus/skills so its tests ride along, and pin that in the preflight tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: Ib8058de42a469d080f0242d1c2394f0e120cfaa0
5 tasks
Owner
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Sep 17, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
Owner
Author
|
@Mergifyio queue admin-bypass |
Contributor
Merge Queue Status
This pull request spent 8 minutes 13 seconds in the queue, including 19 minutes 19 seconds running CI. Required conditions to merge
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A change that adds a shared rule plus the one check that pins it now counts as a single piece of review work.
The rules file the agent loads each session is plain text.
The tool that splits a change into review pieces filed it under docs, going by file type alone.
So any check added beside it landed in a second piece, and a pull request pairing a new rule with its check could never pass as one.
Now that file is grouped with the lesson folder it belongs to, so a check that rides along with it stays in the same piece.
Review Claim
The shared rules file now groups with the lessons, and a check added next to it stays neutral.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
Only the one path rule is added; every other path keeps its unit, and the preflight and the Node PR checker still agree on every tracked path.
Slice Rationale
The rule slices above it each pair a learned rule with its test, and they can only pass as single units once this lands.
Non-goals
corpus/skills/**, docs, or tests are classified.Test Plan
Test Plan
python3 -m unittest engine/skills/make-pr/tests/test_preflight.py: the new classification test fails before the config line and passes after;Ran 33 tests ... OKincluding the drafter-core parity test (afternpm ci).github/workflows/ci.ymlran locally on the full stack with rc=0:run_all_tests.sh,check_no_tracked_local_artifacts,check_hook_test_coverage,check_no_silent_hook_except,check_rules_are_wired,check_skills_three_harnesses,check_ecosystem_boundaries,check_skill_file_refs,check_skill_test_coverage,check_skill_test_debt_no_growth,check_skill_trigger_mechanism,check_dora_baseline,check_no_dated_provenance,check_no_new_comments,ruff check . --select E9,F,shellcheck install.shRevert Plan
Revert Plan
git revert <sha>./install.shso installed copies match🤖 Generated with Claude Code