Skip to content

Count a background job as the wakeup behind an ETA, and call the time an estimate - #735

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
Sep 17, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

A background command that exits when its job finishes now counts as the wakeup behind an ETA, and the named time is called an estimate.

The guard that enforces this already accepts that kind of exit. The written rule named only the scheduled-wakeup tool, so rule and guard disagreed.

Review Claim

The waiting rule now matches what the guard actually accepts as a wakeup for a background job.

Review Lane

behavior

Review Unit

corpus-lesson

Safety Invariant

An ETA still needs a live wakeup; the hook's behavior is unchanged and the test runs its real decision function.

Slice Rationale

One rule and the test that ties it to the hook.

Non-goals

  • No change to the wait-needs-wakeup hook.

Test Plan

Test Plan
  • python3 -m unittest tests.test_cat_mode: the new TestCatModeEtaMatchesWaitHook checks fail before the prose change and pass after; cat-mode stays at 299 of 300 lines
  • Every step in .github/workflows/ci.yml ran locally on the full stack with rc=0: run_all_tests.sh, check_no_tracked_local_artifacts, check_hook_test_coverage, check_no_silent_hook_except, check_rules_are_wired, check_skills_three_harnesses, check_ecosystem_boundaries, check_skill_file_refs, check_skill_test_coverage, check_skill_test_debt_no_growth, check_skill_trigger_mechanism, check_dora_baseline, check_no_dated_provenance, check_no_new_comments, ruff check . --select E9,F, shellcheck install.sh

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: rerun ./install.sh so installed copies match
  • Data migration? No

🤖 Generated with Claude Code

@EdbertChan

EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 Count a background job as the wakeup behind an ETA, and call the time an estimate #735 👈
2 Run list loops under bash, not zsh #736
3 Read a script's whole body before asking to run it #737
4 Reconcile declared intent, code, and result when finishing a merge #738
5 Keep approved fix-later items in every status update #739
6 Search saved memory both ways before a deep dive #740

@EdbertChan

EdbertChan commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial 5fc502e 2026-09-17 04:23 UTC
2 rebase 5fc502e → 86d94a8 (rebase only) 2026-09-17 04:23 UTC
3 rebase 86d94a8 → 1e0bb34 (rebase only) 2026-09-17 04:37 UTC

… an estimate

cat-mode said only a ScheduleWakeup backs an ETA, while the wait-needs-wakeup
hook also accepts a background command or agent that exits on its condition.
Align the prose with the hook, label clock times as estimates, and add a test
that ties the prose to the hook's own decision.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I216f96591e16d1f3ab52edd0d32f1e536ea6d752
@EdbertChan
EdbertChan changed the base branch from stack/EdbertChan/feat/memory-rules-into-catstack/park-abandoned-work-branch-worktree-never-git--d0971253 to main September 17, 2026 04:37
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659 branch from 86d94a8 to 1e0bb34 Compare September 17, 2026 04:37
@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 1 second in the queue, including 6 minutes 37 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@mergify mergify Bot added the queued label Sep 17, 2026
@mergify
mergify Bot merged commit ddbacf1 into main Sep 17, 2026
7 of 12 checks passed
@mergify mergify Bot removed the queued label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant