Count a background job as the wakeup behind an ETA, and call the time an estimate - #735
Merged
Conversation
3 tasks
Owner
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Sep 17, 2026
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
branch
from
September 17, 2026 04:23
5fc502e to
86d94a8
Compare
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/park-abandoned-work-branch-worktree-never-git--d0971253
branch
from
September 17, 2026 04:23
c2194f6 to
39d3655
Compare
Owner
Author
Revision history
|
… an estimate cat-mode said only a ScheduleWakeup backs an ETA, while the wait-needs-wakeup hook also accepts a background command or agent that exits on its condition. Align the prose with the hook, label clock times as estimates, and add a test that ties the prose to the hook's own decision. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I216f96591e16d1f3ab52edd0d32f1e536ea6d752
EdbertChan
changed the base branch from
stack/EdbertChan/feat/memory-rules-into-catstack/park-abandoned-work-branch-worktree-never-git--d0971253
to
main
September 17, 2026 04:37
EdbertChan
force-pushed
the
stack/EdbertChan/feat/memory-rules-into-catstack/count-background-job-wakeup-behind-eta-call-time--216f9659
branch
from
September 17, 2026 04:37
86d94a8 to
1e0bb34
Compare
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 7 minutes 1 second in the queue, including 6 minutes 37 seconds running CI. Required conditions to merge
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A background command that exits when its job finishes now counts as the wakeup behind an ETA, and the named time is called an estimate.
The guard that enforces this already accepts that kind of exit. The written rule named only the scheduled-wakeup tool, so rule and guard disagreed.
Review Claim
The waiting rule now matches what the guard actually accepts as a wakeup for a background job.
Review Lane
behavior
Review Unit
corpus-lesson
Safety Invariant
An ETA still needs a live wakeup; the hook's behavior is unchanged and the test runs its real decision function.
Slice Rationale
One rule and the test that ties it to the hook.
Non-goals
Test Plan
Test Plan
python3 -m unittest tests.test_cat_mode: the newTestCatModeEtaMatchesWaitHookchecks fail before the prose change and pass after; cat-mode stays at 299 of 300 lines.github/workflows/ci.ymlran locally on the full stack with rc=0:run_all_tests.sh,check_no_tracked_local_artifacts,check_hook_test_coverage,check_no_silent_hook_except,check_rules_are_wired,check_skills_three_harnesses,check_ecosystem_boundaries,check_skill_file_refs,check_skill_test_coverage,check_skill_test_debt_no_growth,check_skill_trigger_mechanism,check_dora_baseline,check_no_dated_provenance,check_no_new_comments,ruff check . --select E9,F,shellcheck install.shRevert Plan
Revert Plan
git revert <sha>./install.shso installed copies match🤖 Generated with Claude Code