Skip to content

[WIP] Migrate to the NamedGraphs v0.14 interface - #126

Draft
mtfishman wants to merge 1 commit into
mainfrom
mf/namedgraphs-v0.14
Draft

[WIP] Migrate to the NamedGraphs v0.14 interface#126
mtfishman wants to merge 1 commit into
mainfrom
mf/namedgraphs-v0.14

Conversation

@mtfishman

Copy link
Copy Markdown
Member

Summary

NamedGraphs v0.14 replaced the position-graph interface with encode and decode, and removed the submodules DataGraphs imported from, so main cannot load against it at all. Also clears the five method ambiguities the migration surfaced, turns on the Aqua check guarding them, and fixes two bugs in quotient_graph over a PartitionedView.

TODO

  • Remove the [sources] pin on NamedGraphs main and confirm [compat] admits the registered version, once NamedGraphs 0.14 registers.
  • Add a changelog recording the breaking changes, including the ones inherited through NamedGraphs: vertices now returns Dictionaries.Indices in insertion order, edges is a lazy iterator, and the mutating functions return Bool.
  • Documentation pass: the package has one docstring and no doctests.

NamedGraphs v0.14 replaced the position-graph interface with encode and decode, and removed the submodules DataGraphs imported from, so `main` cannot load against it at all. Also clears the five method ambiguities the migration surfaced and turns on the Aqua check guarding them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant