[WIP] Migrate to the NamedGraphs v0.14 interface - #174
Draft
mtfishman wants to merge 2 commits into
Draft
Conversation
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported, so it no longer loads. The overloads move to the encode and decode interface, and the dead imports go with them, since an import of a removed name fails at load rather than merely being noise.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 79.35% 80.17% +0.82%
==========================================
Files 13 13
Lines 683 681 -2
==========================================
+ Hits 542 546 +4
+ Misses 141 135 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Graphs.jl documents these as returning whether the operation happened, and DataGraphs now does too, so returning the network or cache left this package inconsistent with its own base class. Also fixes `add_vertex!` on a `MessageCache`, which called `add_edge!` and so could never succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported, so it no longer loads. The overloads move to the encode and decode interface, and the mutating ones now return
Boolas Graphs.jl documents, which also turned up anadd_vertex!on aMessageCachethat could never succeed.TODO
[sources]pins on NamedGraphsmainand on the DataGraphs migration branch, once NamedGraphs 0.14 and DataGraphs 0.6.0 register. The DataGraphs pin is needed because its registered 0.5.3 caps NamedGraphs at 0.13, so the NamedGraphs pin alone cannot resolve. It tracks [WIP] Migrate to the NamedGraphs v0.14 interface DataGraphs.jl#126.