[WIP] Migrate to the NamedGraphs v0.14 interface - #385
Draft
mtfishman wants to merge 1 commit into
Draft
Conversation
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported. The 0.21 line gets the migration too, so dependents can move to NamedGraphs v0.14 without also taking on the API removals accumulated in 0.22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported. The 0.21 line gets the migration too, so dependents can move to NamedGraphs v0.14 without also taking on the API removals accumulated in 0.22.
TODO
0.21.5, since raising the NamedGraphs floor breaks anything pinning the old range, which argues for a minor bump, butmainalready holds0.22.[sources]pins on NamedGraphsmainand on the DataGraphs migration branch, once NamedGraphs 0.14 and DataGraphs 0.6.0 register. The DataGraphs pin is needed because its registered 0.5.3 caps NamedGraphs at 0.13. It tracks [WIP] Migrate to the NamedGraphs v0.14 interface DataGraphs.jl#126.