Skip to content

Remove dead LibraryDevelopment and LocalLibrary build targets #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasonleenaylor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove dead LibraryDevelopment and LocalLibrary build targets #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ GeneratedAssemblyInfo.cs
Collection.cpp
.vs/
Build/GlobalInclude.properties
Build/LibraryDevelopment.properties
Build/NuGet.exe
Build/nunit.framework.dll
Build/nunit.framework.xml
Expand Down
50 changes: 0 additions & 50 deletions Build/DownloadLibraryDependencies.pl
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Build/InstallerBuild.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
<Import Project="$(MSBuildThisFileDirectory)RegFree.targets"/>
<Import Project="$(MSBuildThisFileDirectory)Installer.Wix3.targets" Condition="'$(OS)'=='Windows_NT' and '$(InstallerToolset)'=='Wix3'"/>
<Import Project="$(MSBuildThisFileDirectory)Installer.targets" Condition="'$(OS)'=='Windows_NT' and '$(InstallerToolset)'=='Wix6'"/>
<Import Project="$(MSBuildThisFileDirectory)LocalLibrary.targets"/>

<!-- BuildInstaller target is imported from Installer.Wix3.targets or Installer.targets (Wix6) -->

Expand Down
57 changes: 0 additions & 57 deletions Build/LibraryDevelopment.targets
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions Build/LocalLibrary.targets
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions Build/Localize.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@
<Target Name="VerifyLcmCloned">
<Error
Text="LcmSrcDir '$(LcmSrcDir)' was not found.
To update localizations, liblcm must be cloned locally to the location specified by %24LcmRootDir
(historically set in $(MSBuildThisFileDirectory)LibraryDevelopment.properties; now an environment variable)."
To update localizations, liblcm must be cloned locally to the location specified by the
%24LcmRootDir environment variable."
Condition="!Exists('$(LcmSrcDir)')"
/>
</Target>
Expand Down
5 changes: 0 additions & 5 deletions Build/PackageRestore.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,18 +250,13 @@
<ItemGroup>
<SILNugetFiles Include="$(PackagesDir)/$([System.String]::new('%(SILNugetPackages.Identity)').ToLower())/%(SILNugetPackages.Version)/%(SILNugetPackages.Path)" />
</ItemGroup>
<!-- TODO (Hasso) 2011.11: copy on Condition="'$(UseLocalLibraries)'!='Y'" -->
<Message Text="Copying artifacts from Palaso, Chorus, LCM, and related packages to Downloads." />
<Copy
SourceFiles="@(SILNugetFiles)"
DestinationFolder="$(DownloadsDir)/%(RecursiveDir)"
SkipUnchangedFiles="true"
OverwriteReadOnlyFiles="true"
/>
<Message
Text="(Palaso, Chorus, and LCM artifacts will be copied to Output from $(PalasoArtifactsDir), $(ChorusArtifactsDir), and $(LcmArtifactsDir), respectively, as specified in LibraryDevelopment.targets)"
Condition="'$(UseLocalLibraries)'=='Y'"
/>
<!-- ExCss.dll is now provided by the SIL.ExCSS NuGet package (no TeamCity download needed). -->
<!-- GeckofxHtmlToPdf binaries downloaded from GitHub release (replaces decommissioned TeamCity server). -->
<DownloadFile
Expand Down
1 change: 0 additions & 1 deletion openspec/specs/architecture/build-deploy/build-phases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ Also hosts `BuildWindowsXslAssemblies` (invoked by `Directory.Build.targets` for
| `Build/FwBuildTasks.targets` | UsingTask declarations for custom MSBuild tasks (Make, RegFree, etc.) | InstallerBuild.proj, NativeBuild.csproj |
| `Build/RegFree.targets` | Registration-free COM manifest generation | InstallerBuild.proj, NativeBuild.csproj |
| `Build/Localize.targets` | Crowdin localization integration | InstallerBuild.proj, NativeBuild.csproj |
| `Build/LocalLibrary.targets` | Local Palaso/LCM/Chorus development overrides | InstallerBuild.proj |
| `Build/SilVersions.props` | SIL ecosystem version numbers (shared with Directory.Packages.props) | PackageRestore.targets |
| `Build/Installer.Wix3.targets` | WiX 3 installer entry point | InstallerBuild.proj |
| `Build/Installer.targets` | WiX 6 installer pipeline | InstallerBuild.proj |
Expand Down
Loading