Remove dead LibraryDevelopment and LocalLibrary build targets - #1113
Draft
jasonleenaylor wants to merge 1 commit into
Draft
Remove dead LibraryDevelopment and LocalLibrary build targets#1113jasonleenaylor wants to merge 1 commit into
jasonleenaylor wants to merge 1 commit into
Conversation
Build/LibraryDevelopment.targets lost its only importer when Build/FieldWorks.proj was deleted, and it still called an MSBuild.ExtensionPack console task whose UsingTask and package are both gone. Build/LocalLibrary.targets held a LocalLibrary target that no target or script invoked, passing a LibpalasoPlatform property defined nowhere. Manage-LocalLibraries.ps1 replaced both. Deleted the two .targets files, dropped the LocalLibrary.targets import from InstallerBuild.proj, and removed the two UseLocalLibraries reads in PackageRestore.targets, which gated only a Message nothing could reach. Nothing outside LocalLibrary.targets referenced its items or properties, so InstallerBuild.proj needs no replacement. Also deleted DownloadLibraryDependencies.pl, whose only input was the generated LibraryDevelopment.properties, dropped that file's .gitignore entry, and pruned the stale references in the Localize.targets error text and openspec build-phases.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
+ Coverage 38.34% 38.36% +0.01%
==========================================
Files 1507 1507
Lines 350586 350634 +48
Branches 40294 40304 +10
==========================================
+ Hits 134432 134505 +73
+ Misses 186927 186897 -30
- Partials 29227 29232 +5 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build/LibraryDevelopment.targets lost its only importer when
Build/FieldWorks.proj was deleted, and it still called an
MSBuild.ExtensionPack console task whose UsingTask and package are
both gone. Build/LocalLibrary.targets held a LocalLibrary target that
no target or script invoked, passing a LibpalasoPlatform property
defined nowhere. Manage-LocalLibraries.ps1 replaced both.
Deleted the two .targets files, dropped the LocalLibrary.targets
import from InstallerBuild.proj, and removed the two UseLocalLibraries
reads in PackageRestore.targets, which gated only a Message nothing
could reach. Nothing outside LocalLibrary.targets referenced its items
or properties, so InstallerBuild.proj needs no replacement.
Also deleted DownloadLibraryDependencies.pl, whose only input was the
generated LibraryDevelopment.properties, dropped that file's .gitignore
entry, and pruned the stale references in the Localize.targets error
text and openspec build-phases.md.
Why these were unreachable
Both halves are leftovers from the migration in #789 (90bbc7a), which
replaced the shell half with
Build/Manage-LocalLibraries.ps1anddeleted
Build/buildLocalLibraries.sh, but left the MSBuild halvesbehind.
LibraryDevelopment.targetswas orphaned earlier still, whenBuild/FieldWorks.projwent away in 5711bf6 (#678), and c2b1ffahad already removed the
UsingTaskfor the console task that lines 14and 18 still call.
UseLocalLibrariesis set by nothing today — no CIworkflow, script, or doc passes
/p:UseLocalLibraries=Y, so the onepath that could still reach the dead branch does not exist.
PalasoArtifactsDir/ChorusArtifactsDir/LcmArtifactsDirremainlive and untouched: their defaults in PackageRestore.targets and
Directory.Build.props and all seven consumers are unchanged. Only their
UseLocalLibraries-gated paths are gone.build.ps1 -UseLocalLcmandscripts/Agent/Copy-LocalLcm.ps1are also untouched — that is a fastpost-restore DLL overlay, complementary to Manage-LocalLibraries.ps1
rather than redundant with it.
Validation
.\build.ps1 -CommentHygiene— clean full native + managed build,0 warnings, 0 errors.
.\test.ps1 -CommentHygiene— exit 0, all 5897 tests passed./pppreprocess ofInstallerBuild.projresolvesBuildInstallerwith zero references toPalasoFileNamesForLL,ChorusDeps,ConfigName,LiblcmPlatform, orChorusPlatform.BuildWindowsXslAssembliesandVerifyLcmClonedboth execute fromInstallerBuild.projafter the import removal.Installer.legacy.targetsandfails at
buildBaseInstaller.bat(exit 9009). Restoring all threefiles and the import reproduces that failure byte-for-byte at the
same line, so it is pre-existing and unrelated.
This change is