Skip to content

fix(release): pack platform clients by relative path #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremi merged 2 commits into from
Aug 13, 2026
Merged

fix(release): pack platform clients by relative path #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a2e93
fix(release): pack platform clients by relative path
jeremi Aug 13, 2026
3bf7cd1
fix(release): publish npm tarballs by relative path
jeremi Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ jobs:
cp "${client_dir}/${client}-client.${{ matrix.napi_platform }}.node" \
"${platform_dir}/"
(cd "${client_dir}" && npm pack \
"npm/${{ matrix.napi_platform }}" \
"./npm/${{ matrix.napi_platform }}" \

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

Commit 7cc861cf9e370fbc1102bbd8917ca9bf4cecf419 has no Signed-off-by: trailer, so it does not satisfy the repository's mandatory DCO policy and will be blocked from compliant integration; recreate this change with an appropriate sign-off.

AGENTS.md reference: AGENTS.md:L274-L274

Useful? React with 👍 / 👎.

--ignore-scripts --pack-destination "${RUNNER_TEMP}")
platform_package="registrystack-${client}-client-${{ matrix.napi_platform }}-${CLIENT_VERSION}.tgz"
test -f "${RUNNER_TEMP}/${platform_package}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ jobs:
--tarball "${tarball}")"
if [[ "${state}" == absent ]]; then
require_unexpired_candidate
npm publish "${tarball}" --access public --provenance
npm publish "./${tarball}" --access public --provenance
else
test "${state}" = present
fi
Expand Down
4 changes: 3 additions & 1 deletion release/scripts/test_release_workflow_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ def test_builds_and_smokes_stable_native_client_packages(self) -> None:
"package/${client}-client.${{ matrix.napi_platform }}.node",
node,
)
self.assertIn('"./npm/${{ matrix.napi_platform }}"', node)
self.assertIn("registry-${client}-client-node", node)
for name in ("Smoke Python client wheels", "Smoke Node client packages"):
smoke = step_run(document, "clients", name)
Expand Down Expand Up @@ -1016,7 +1017,8 @@ def test_promotes_exact_client_packages_with_oidc_and_retry_safety(self) -> None
"Reconcile platform packages, then publish the root package",
)
self.assertIn("client_registry.py npm-state", npm_publish)
self.assertIn("npm publish", npm_publish)
self.assertIn('npm publish "./${tarball}"', npm_publish)
self.assertNotIn('npm publish "${tarball}"', npm_publish)
self.assertIn("require_unexpired_candidate", npm_publish)
self.assertLess(
npm_publish.rindex("require_unexpired_candidate"),
Expand Down