fix(release): pack platform clients by relative path - #772
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bf7cd1b18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "${platform_dir}/" | ||
| (cd "${client_dir}" && npm pack \ | ||
| "npm/${{ matrix.napi_platform }}" \ | ||
| "./npm/${{ matrix.napi_platform }}" \ |
There was a problem hiding this comment.
Commit 7cc861cf9e370fbc1102bbd8917ca9bf4cecf419 has no Signed-off-by: trailer, so it does not satisfy the repository's mandatory DCO policy and will be blocked from compliant integration; recreate this change with an appropriate sign-off.
AGENTS.md reference: AGENTS.md:L274-L274
Useful? React with 👍 / 👎.
1 participant
Incident
Candidate run 31742816713 stopped in all three native client matrices:
ssh://git@github.com/npm/linux-arm64-gnu.gitssh://git@github.com/npm/linux-x64-gnu.gitssh://git@github.com/npm/darwin-arm64.gitThe workflow passed
npm/<platform>to npm 10.9 without an explicit relative prefix, so npm interpreted the value as GitHub shorthand instead of the checked-in package directory.Fix
./npm/<platform>.Verification
git diff --check: passedThis changes candidate workflow control only. It does not change release payload content or rewrite release history. After merge, beta-33 must be rebuilt and verified as a new candidate from the new protected-main source.