Skip to content

Raise the vector over-fetch to 4x so every collection fills its budget #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamjohnwright wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Raise the vector over-fetch to 4x so every collection fills its budget #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/retrievers/csv_chroma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@
# pathway/input/output/catalyst combination -- and those rows have distinct
# page_content, so nothing upstream collapses them. Without over-fetching, a
# request for 10 returns about 5 distinct reactions. See issue #169.
VECTOR_OVERFETCH = 3
#
# 4x, not 3x: measured over the 20 questions in tests/golden/questions.txt, 3x
# still came up short on `complexes` for one of them (8 distinct of 10). 4x
# clears all 20 on every collection and 6x gains nothing further.
VECTOR_OVERFETCH = 4

# How many fused documents each collection contributes to the answer prompt.
#
Expand Down
Loading