fix: remove asyncio.run() from __del__ to prevent production crashes - #156
Closed
bleedblack1 wants to merge 1 commit into
Closed
fix: remove asyncio.run() from __del__ to prevent production crashes#156bleedblack1 wants to merge 1 commit into
bleedblack1 wants to merge 1 commit into
Conversation
Contributor
|
Thank you — you both independently found this, which is what made it credible. Fixed on
The change closes the pool only when no loop is running, and otherwise warns that it is still open rather than pretending otherwise. Writing the test surfaced that even the warning fails at interpreter shutdown once logging's handlers close — so this is containment, and the real fix is an explicit shutdown hook. Closing as resolved. Your reports are credited in the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
Problem
The
AgentGraph.__del__method crashes in production:Why it crashes:
asyncio.run()cannot be called when an event loop is already running, which is always the case in Chainlit/uvicorn/FastAPI.Secondary issue:
LANGGRAPH_DB_URIis constructed at module import with potentiallyNonevalues, creating malformed URIs.Solution
Related Issues
asyncio.run()crash bug