Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,6 @@
<div class="dropdown" [class.open]="dropdown() === 'analysis'">
<cr-analysis-form (close)="closeAnalysis()" [status]="analysisStatus" />
</div>
<div class="dropdown" [class.open]="dropdown() === 'compare'">
<cr-compare-form (close)="dropdown.set(null)" />
</div>
</as-split-area>

<div
Expand Down
10 changes: 7 additions & 3 deletions projects/pathway-browser/src/app/viewport/viewport.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import { MatMenu, MatMenuItem, MatMenuTrigger } from '@angular/material/menu';
import { MatButton, MatIconButton } from '@angular/material/button';
import { NgClass } from '@angular/common';
import { AnalysisFormComponent } from './analysis-form/analysis-form.component';
import { CompareFormComponent } from './compare-form/compare-form.component';
import { FormsModule } from '@angular/forms';
import { MatRadioButton, MatRadioGroup } from '@angular/material/radio';

Expand Down Expand Up @@ -87,7 +86,6 @@ const DROPDOWN_DURATION = 500;
ReacfoamComponent,
DetailsComponent,
AnalysisFormComponent,
CompareFormComponent,
],
})
@UntilDestroy()
Expand Down Expand Up @@ -168,7 +166,13 @@ export class ViewportComponent implements AfterViewInit {
dropdownDuration = DROPDOWN_DURATION;
readonly isCurator = IS_CURATOR;

dropdown = signal<'analysis' | 'compare' | null>(null);
// Only the analysis form opens here. There was a 'compare' state too, with a
// panel of its own in the template, and nothing anywhere set it -- the form
// behind it was the CLI's `<p>compare-form works!</p>` scaffold, shipped in
// the initial commit and never written. Comparing against a disease variant
// is the Compare button in the toolbar, which navigates rather than opening a
// panel.
dropdown = signal<'analysis' | null>(null);

toggleAnalysis() {
this.dropdown.set(this.dropdown() ? null : 'analysis');
Expand Down
Loading