Skip to content

chore(viewport): drop the compare-form scaffold that was never written - #174

Merged
adamjohnwright merged 1 commit into
mainfrom
chore/remove-compare-form-scaffold
Sep 5, 2026
Merged

chore(viewport): drop the compare-form scaffold that was never written#174
adamjohnwright merged 1 commit into
mainfrom
chore/remove-compare-form-scaffold

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

CompareFormComponent is the Angular CLI's generated placeholder:

<p>compare-form works!</p>

Eleven lines of TypeScript, an empty stylesheet, that template. In the tree since the initial commit, and rendered into every pathway browser page inside a panel that can never open — the panel is gated on dropdown() === 'compare', and nothing anywhere sets that state.

Why bother

It cost me twenty minutes today. Chasing whether the toolbar's Compare button worked, I found a component named compare-form, a dropdown state called 'compare', and no way to reach either — which reads like a broken feature rather than an unfinished one. The next person pays the same.

Comparing against a disease variant is the Compare button in the toolbar, and it works: it opens a menu of the disease variants and navigates to the one you pick. That is the whole feature; nothing is being removed from it.

Changes

  • Delete compare-form/ (3 files).
  • Remove the unreachable panel from viewport.component.html.
  • Narrow dropdown from 'analysis' | 'compare' | null to 'analysis' | null, with a note saying why, so this does not get re-scaffolded.

Verified on beta

  • Compare still lists "Defective Intrinsic Pathway for Apoptosis" and navigates.
  • Analyze still opens its form (.dropdown.open).
  • No cr-compare-form left in the DOM, no console errors.
  • Full preflight green.

`CompareFormComponent` is the Angular CLI's generated placeholder -- eleven
lines of TypeScript, an empty stylesheet, and a template reading
`<p>compare-form works!</p>`. It has been in the tree since the initial
commit, and it renders into every pathway browser page inside a panel that
can never open: the panel is gated on `dropdown() === 'compare'`, and
nothing anywhere sets that state.

It cost me twenty minutes today. Chasing whether the toolbar's Compare
button worked, I found a component named compare-form, a dropdown state
called 'compare', and no way to reach either -- which reads like a broken
feature rather than an unfinished one. Comparing against a disease variant
is the Compare button in the toolbar, and it works: it opens a menu of the
disease variants and navigates. That is the whole feature.

So the state is narrowed to 'analysis' | null, the panel is gone, and the
scaffold with it. Verified on beta: the Compare menu still lists "Defective
Intrinsic Pathway for Apoptosis", Analyze still opens its form, no
cr-compare-form left in the DOM, no console errors.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright enabled auto-merge (squash) September 5, 2026 00:05
@adamjohnwright
adamjohnwright merged commit 4e332d0 into main Sep 5, 2026
6 checks passed
@adamjohnwright
adamjohnwright deleted the chore/remove-compare-form-scaffold branch September 5, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant