chore(viewport): drop the compare-form scaffold that was never written - #174
Merged
Merged
Conversation
`CompareFormComponent` is the Angular CLI's generated placeholder -- eleven lines of TypeScript, an empty stylesheet, and a template reading `<p>compare-form works!</p>`. It has been in the tree since the initial commit, and it renders into every pathway browser page inside a panel that can never open: the panel is gated on `dropdown() === 'compare'`, and nothing anywhere sets that state. It cost me twenty minutes today. Chasing whether the toolbar's Compare button worked, I found a component named compare-form, a dropdown state called 'compare', and no way to reach either -- which reads like a broken feature rather than an unfinished one. Comparing against a disease variant is the Compare button in the toolbar, and it works: it opens a menu of the disease variants and navigates. That is the whole feature. So the state is narrowed to 'analysis' | null, the panel is gone, and the scaffold with it. Verified on beta: the Compare menu still lists "Defective Intrinsic Pathway for Apoptosis", Analyze still opens its form, no cr-compare-form left in the DOM, no console errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompareFormComponentis the Angular CLI's generated placeholder:Eleven lines of TypeScript, an empty stylesheet, that template. In the tree since the initial commit, and rendered into every pathway browser page inside a panel that can never open — the panel is gated on
dropdown() === 'compare', and nothing anywhere sets that state.Why bother
It cost me twenty minutes today. Chasing whether the toolbar's Compare button worked, I found a component named
compare-form, a dropdown state called'compare', and no way to reach either — which reads like a broken feature rather than an unfinished one. The next person pays the same.Comparing against a disease variant is the Compare button in the toolbar, and it works: it opens a menu of the disease variants and navigates to the one you pick. That is the whole feature; nothing is being removed from it.
Changes
compare-form/(3 files).viewport.component.html.dropdownfrom'analysis' | 'compare' | nullto'analysis' | null, with a note saying why, so this does not get re-scaffolded.Verified on beta
.dropdown.open).cr-compare-formleft in the DOM, no console errors.