Skip to content

Fix benchmark file links in Appendix 4 - #5134

Open
mmustafasenoglu wants to merge 1 commit into
pymupdf:mainfrom
mmustafasenoglu:fix/app4-benchmark-links
Open

mmustafasenoglu wants to merge 1 commit into
pymupdf:mainfrom
mmustafasenoglu:fix/app4-benchmark-links

Conversation

@mmustafasenoglu

Copy link
Copy Markdown

Fixes #5126

The benchmark file names in the "Files used" table were written as interpreted text instead of references, so the link targets at the bottom of docs/app4.rst were never used and the table rendered without any download links. The artifex.com sample URLs also return 404 now, so the targets now point to the archived copies at web.archive.org (each archived file's size matches the size column in the table).

Changes:

  • docs/app4.rst: added the trailing _ to the eight file names so they reference the existing targets
  • docs/app4.rst: pointed the eight targets at their web.archive.org copies
  • docs/app4.rst: added a note that the original artifex.com downloads are gone

The file names in the "Files used" table were interpreted text, so the
link targets at the bottom of docs/app4.rst were never referenced and
the table rendered without any download links. Also, the artifex.com
sample URLs return 404 now, so point the targets at the archived copies
at web.archive.org.

Fixes pymupdf#5126
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mmustafasenoglu

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Appendix 4 (Performance Comparison) benchmark files can't be downloaded — table renders no links, and all 8 artifex.com/samples URLs return 404

1 participant