fix(lint): scrub real bench values from test fixtures; add the generic topology guard - #393
Merged
Merged
Conversation
…c topology guard The public tree carried a handful of real local-setup values as test fixtures — a globally-routable IPv6 literal, a real hostname (as a bad-input and a pool-url fixture), and real home paths — each swapped for a same-class placeholder (RFC 3849 documentation prefix, generic host/role names), with every touched assertion updated in step. The suite proves the swaps are behavior-neutral. scripts/lint-topology-classes.sh (ported from the sibling repo, allowlists re-tuned to this tree: generic role homes, the api_allow_from help-example /24, this product's own .local placeholder) wires into make lint as lint-topology, self-test first. The guard teaches nothing about any real setup — every pattern is a class. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXdRGcURkgbuoo5hUG8rmB
The CLI-name comment, the bot-mention self-test fixture, and the exempt-path list still described the sibling repo; this tree has no compose file or build templates to exempt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXdRGcURkgbuoo5hUG8rmB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sibling repo's leak audit and generic topology guard never reached this one; a scan found a handful of real local-setup values sitting in the public tree as test fixtures — one globally-routable IPv6 literal, one real hostname (used as both a bad-input fixture and a pool-url fixture), and real home-directory paths. Classes only here, deliberately; each value was swapped for a same-class placeholder (the RFC 3849 documentation prefix, generic host/role names) with every touched assertion updated in step. History still holds the old values — reported to the operator separately; no history rewrite.
The guard:
scripts/lint-topology-classes.sh, ported from the sibling repo and re-tuned to this tree (generic role homes, theapi_allow_fromhelp-example/24, this product's own.localplaceholder). Five generic classes, per-class value allowlists,--self-testfixtures for every failure mode, and the empty-enumeration refusal. Wired aslint-topologyundermake lint, which CI already invokes — no workflow change needed. The script teaches nothing about any real setup: every pattern is a class.What was RUN:
make lintend-to-end: clean, guard included; the guard's--self-testpasses.make lintred.