Merge stable into develop - #1287
Merged
Merged
Conversation
…messages field (#1279) * fix: stop client.branch.validate() requesting removed BranchValidate.messages field The BranchValidate mutation stopped exposing the messages field in Infrahub 1.1.0, but both validate() variants still requested it (plus an unused object selection), so every call raised a GraphQLError against any supported server. Request only ok, which is the single field the method returns. Adds a unit regression test asserting the rendered mutation no longer contains messages, and integration coverage for both client variants on the existing branch test classes. * test: validate sync-branch01 in sync branch.validate integration test The sync test class's base_dataset creates sync-branch01, not branch01; the test referenced the async class's branch name and failed with BRANCH_NOT_FOUND.
Deploying infrahub-sdk-python with
|
| Latest commit: |
5bbf34c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a642e98a.infrahub-sdk-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1279.
Summary by cubic
Fixes
client.branch.validate()andinfrahubctl branch validate, which raised aGraphQLErroragainst every supported Infrahub server because the mutation requested amessagesfield that was removed fromBranchValidatein Infrahub 1.1.0. The mutation now requests only theokfield, and tests were added to cover both async and sync clients.Written for commit 5bbf34c. Summary will update on new commits.