Skip to content

Merge develop into infrahub-develop - #1288

Merged
infrahub-github-bot-app[bot] merged 2 commits into
infrahub-developfrom
develop
Aug 27, 2026
Merged

Merge develop into infrahub-develop#1288
infrahub-github-bot-app[bot] merged 2 commits into
infrahub-developfrom
develop

Conversation

@infrahub-github-bot-app

@infrahub-github-bot-app infrahub-github-bot-app Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Merging develop into infrahub-develop after merging pull request #1287.


Summary by cubic

Merges develop into infrahub-develop, fixing client.branch.validate() and infrahubctl branch validate so they no longer request the removed messages field from the BranchValidate mutation and thus no longer raise a GraphQLError against Infrahub 1.1.0 and later.

Written for commit 0e11153. Summary will update on new commits.

Review in cubic

ogenstad and others added 2 commits August 26, 2026 21:03
…messages field (#1279)

* fix: stop client.branch.validate() requesting removed BranchValidate.messages field

The BranchValidate mutation stopped exposing the messages field in
Infrahub 1.1.0, but both validate() variants still requested it (plus an
unused object selection), so every call raised a GraphQLError against any
supported server. Request only ok, which is the single field the method
returns.

Adds a unit regression test asserting the rendered mutation no longer
contains messages, and integration coverage for both client variants on
the existing branch test classes.

* test: validate sync-branch01 in sync branch.validate integration test

The sync test class's base_dataset creates sync-branch01, not branch01;
the test referenced the async class's branch name and failed with
BRANCH_NOT_FOUND.
Merge stable into develop
@infrahub-github-bot-app
infrahub-github-bot-app Bot requested a review from a team as a code owner August 26, 2026 19:48
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e11153
Status: ✅  Deploy successful!
Preview URL: https://5f5d3c97.infrahub-sdk-python.pages.dev
Branch Preview URL: https://develop.infrahub-sdk-python.pages.dev

View logs

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                 Coverage Diff                  @@
##           infrahub-develop    #1288      +/-   ##
====================================================
+ Coverage             84.46%   84.57%   +0.11%     
====================================================
  Files                   147      148       +1     
  Lines                 13296    13373      +77     
  Branches               1930     1953      +23     
====================================================
+ Hits                  11230    11310      +80     
+ Misses                 1503     1496       -7     
- Partials                563      567       +4     
Flag Coverage Δ
integration-tests 40.19% <100.00%> (+0.02%) ⬆️
python-3.10 58.07% <100.00%> (+0.26%) ⬆️
python-3.11 58.07% <100.00%> (+0.28%) ⬆️
python-3.12 58.07% <100.00%> (+0.28%) ⬆️
python-3.13 58.07% <100.00%> (+0.28%) ⬆️
python-3.14 58.07% <100.00%> (+0.26%) ⬆️
python-filler-3.12 23.10% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/branch.py 90.24% <100.00%> (+8.13%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@infrahub-github-bot-app
infrahub-github-bot-app Bot merged commit bbcb11a into infrahub-develop Aug 27, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant