Skip to content

Fix jcenter-dependent BIP39/Base58 deps (switch to JitPack) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SafraNako wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix jcenter-dependent BIP39/Base58 deps (switch to JitPack) #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,12 @@
</developers>

<repositories>
<!-- jcenter was sunset in 2022; these two novacrypto artifacts were
never published anywhere else, so they're pulled from JitPack,
which builds them straight from GitHub. -->
<repository>
<id>jcenter</id>
<url>https://jcenter.bintray.com/</url>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>

Expand All @@ -67,14 +70,22 @@
<version>4.5.13</version>
</dependency>

<!-- io.github.novacrypto:BIP39:0.1.9 is unavailable now that jcenter
is gone, and 0.1.9 was never git-tagged upstream so JitPack can't
build it either (com.github.NovaCrypto:BIP39:0c4ad2db, the commit
tagged "0.1.9" in the changelog, fails to build on JitPack: its
own build.gradle still pulls Gradle plugins from jcenter). 0.1.8
is the closest buildable release; the only change since is to
MnemonicValidator/SeedCalculatorByWordListLookUp, neither of
which this SDK uses (see MnemonicCode.java, HdPrivateKey.java). -->
<dependency>
<groupId>io.github.novacrypto</groupId>
<groupId>com.github.NovaCrypto</groupId>
<artifactId>BIP39</artifactId>
<version>0.1.9</version>
<version>0.1.8</version>
</dependency>

<dependency>
<groupId>io.github.novacrypto</groupId>
<groupId>com.github.NovaCrypto</groupId>
<artifactId>Base58</artifactId>
<version>0.1.2</version>
</dependency>
Expand Down