Fix jcenter-dependent BIP39/Base58 deps (switch to JitPack) - #263
Open
SafraNako wants to merge 1 commit into
Open
Fix jcenter-dependent BIP39/Base58 deps (switch to JitPack)#263SafraNako wants to merge 1 commit into
SafraNako wants to merge 1 commit into
Conversation
jcenter shut down in 2022, so io.github.novacrypto:BIP39:0.1.9 and :Base58:0.1.2 no longer resolve (this breaks downstream builds too, e.g. ontio/ontology-explorer#330). Base58 0.1.2 builds fine on JitPack under com.github.NovaCrypto. BIP39 0.1.9 doesn't: it was never git-tagged upstream, and building the untagged commit on JitPack fails because BIP39's own build.gradle still pulls its Gradle plugins from jcenter. 0.1.8 is the closest buildable release; the only behavioral change since is in MnemonicValidator and SeedCalculatorByWordListLookUp, neither of which this SDK calls (MnemonicCode.java only uses MnemonicGenerator/ SeedCalculator/Words/English; HdPrivateKey.java only uses SeedCalculator/English). Verified both coordinates resolve on JitPack directly; could not run a full local Maven build in this environment. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jcenter shut down in 2022, so
io.github.novacrypto:BIP39:0.1.9and:Base58:0.1.2no longer resolve — the build fails with:(This is also what breaks
ontio/ontology-explorer's build, sinceontsynhandlerthere depends on this SDK — see ontio/ontology-explorer#330.)What
Switches the
jcenterrepository to JitPack and repoints both dependenciesat
com.github.NovaCrypto, JitPack's coordinates for the same GitHub repos.Base58 0.1.2 — unchanged version, builds cleanly on JitPack. Verified:
https://jitpack.io/com/github/NovaCrypto/Base58/0.1.2/Base58-0.1.2.pom→ 200.BIP39 — can't stay on 0.1.9: that version was never git-tagged upstream
(only published to jcenter), and building the untagged commit on JitPack
fails because BIP39's own
build.gradlestill pulls its Gradle plugins fromjcenter too. 0.1.8 is the closest tag that actually builds on JitPack
(verified:
.../BIP39/0.1.8/BIP39-0.1.8.pom→ 200).The only code that changed between 0.1.8 and 0.1.9 is in
MnemonicValidatorandSeedCalculatorByWordListLookUp. This SDK doesn'tcall either —
MnemonicCode.javaonly usesMnemonicGenerator,SeedCalculator,Words,English, andHdPrivateKey.javaonly usesSeedCalculator/English— so the downgrade shouldn't change behaviorhere.
Testing
I don't have a working local Maven/JDK setup in this environment, so I
couldn't run a full build. I did verify both new coordinates resolve and
build successfully via JitPack directly (the
.pomrequests above), andchecked every call site of the changed BIP39 classes in this repo to confirm
none of them are used. Flagging the lack of a local build run in case a
maintainer wants to double check before merging.