ci(publish-images): register the release tag on every scope image artifact - #248
Merged
Merged
Conversation
…ifact The three np artifact create steps passed only the digest, so the global artifacts for containers, scheduled-task and containers-datadog carry no tag and cannot be resolved with `lookup = true` + meta.tag, unlike the images published through release-publish-oci. Pass the release tag too.
sebasnallar
approved these changes
Sep 8, 2026
This was referenced Sep 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué pasa hoy
publish-images.ymlregistra las tres imágenes (containers,scheduled-task,containers-datadog) como artifacts globales con--digestsolamente. Las revisiones quedan sintag:Los repos que publican por
release-publish-oci.ymlde actions-nullplatform (lambda, s3, rds) sí registran--tag, y sus artifacts se resuelven desde tofu-modules v7.4.0 conlookup = trueymeta.tag = "v0.5.0", sin copiar digests a mano. Los de este repo no: tofu-modules 7.4 solo puede encontrarlos por digest, que es exactamente lo que el lookup por tag quería evitar.Qué cambia
Los tres
np artifact createpasan además--tag "${{ inputs.existing_tag || github.ref_name }}", la misma expresión que ya usa el workflow para taggear la imagen en ECR. A partir de la próxima release, cada artifact trae digest y tag, ylookuppor tag funciona igual que para lambda, s3 y rds.Las revisiones ya publicadas no cambian, son inmutables. Si hace falta que una versión existente tenga tag, alcanza con registrar una revisión nueva con el mismo digest más el tag, o cortar una release nueva.