fix(publish): pin GH_REPO in finalize-release - #246
Merged
Merged
Conversation
… infer the repo The finalize job never checks out, so gh release create/edit died with 'not a git repository' on the first run where it actually executed (v1.16.1 backfill — builds and registrations all green). GH_REPO makes gh target the repo explicitly. The v1.16.1 release was created manually with that run's digests; the guard keeps re-runs idempotent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
agustincelentano
approved these changes
Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.16.1 backfill (run 34124727014) finally got everything green — all three images pushed under the hyphen names, all three artifacts registered — and then
finalize-releasedied withfailed to run git: fatal: not a git repository: the job has no checkout, andgh release create/editinfers the repository from git whenGH_REPOisn't set. (Every earlier run skipped this job, so the bug never had a chance to fire.)One-line fix:
GH_REPO: ${{ github.repository }}in the job env. Thegh api repos/$GITHUB_REPOSITORY/…calls never needed it; thegh releaseporcelain does.v1.16.1 itself is already recovered: I created the release manually with that run's exact digests (containers
912b877e…, scheduled-taskc2604ce5…, containers-datadog47c5b1a9…). The digest guard in the workflow keeps any future re-run idempotent against it.🤖 Generated with Claude Code