Skip to content

Update to topic souporcell - #12783

Open
LouisLeNezet wants to merge 5 commits into
nf-core:masterfrom
LouisLeNezet:souporcell
Open

Update to topic souporcell#12783
LouisLeNezet wants to merge 5 commits into
nf-core:masterfrom
LouisLeNezet:souporcell

Conversation

@LouisLeNezet

@LouisLeNezet LouisLeNezet commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #12729

  • vcf variantsMD5Keys doesn't work due to undeterministic process with freebayes (from what I could understand) and because cpus = 1 crash the tool.

  • second test was removed as it just used the default values of each parameter.

  • nft-utils also needs to be set at the end of the plugins as it depends on nft-vcf that needs to be loaded beforehand.

  • This comment contains a description of changes (with reason).

  • If you've fixed a bug or added code that should be tested, add tests!

  • If you've added a new tool - have you followed the module conventions in the contribution docs

  • If necessary, include test data in your PR.

  • Remove all TODO statements.

  • Broadcast software version numbers to topic: versions - See version_topics

  • Follow the naming conventions.

  • Follow the parameters requirements.

  • Follow the input/output options guidelines.

  • Add a resource label

  • Use BioConda and BioContainers if possible to fulfil software requirements.

  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:

    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Aug 24, 2026
@LouisLeNezet
LouisLeNezet requested review from a team as code owners August 24, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to topic souporcell

1 participant