-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add review guidance for deprecated components #32620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Edward Chen (edgchen1)
merged 2 commits into
main
from
edgchen1/deprecation_agent_instructions
Sep 17, 2026
+61
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| description: "Review guidance for changes to the deprecated ACL execution provider and its eventual removal." | ||
| applyTo: "onnxruntime/core/providers/acl/**,include/onnxruntime/core/providers/acl/**,cmake/onnxruntime_providers_acl.cmake" | ||
| --- | ||
|
|
||
| # Deprecated ACL Execution Provider | ||
|
|
||
| The ACL EP is deprecated and will be removed in a future release. | ||
|
|
||
| ## Review Policy | ||
|
|
||
| Report changes that expand or prolong the deprecated ACL EP surface and require explicit maintainer justification | ||
| that the scope is appropriate. | ||
|
|
||
| Accept changes that directly remove code or enable removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| description: "Review guidance for changes to the deprecated JSEP implementation and its removal or migration." | ||
| applyTo: "onnxruntime/core/providers/js/**,onnxruntime/contrib_ops/js/**,js/web/lib/wasm/jsep/**,onnxruntime/wasm/pre-jsep.js,cmake/onnxruntime_providers_js.cmake,js/build_jsep.bat" | ||
| --- | ||
|
|
||
| # Deprecated JSEP | ||
|
|
||
| JSEP is deprecated and is being replaced by the native WebGPU EP. Follow the contribution policy in | ||
| [`docs/JSEP_Deprecation.md`](../../docs/JSEP_Deprecation.md), which is the authoritative source for its status and | ||
| accepted changes. | ||
|
|
||
| ## Review Policy | ||
|
|
||
| Report new operators, features, or performance-only work as actionable findings and direct that work to the native | ||
| WebGPU EP in `onnxruntime/core/providers/webgpu/` or `onnxruntime/contrib_ops/webgpu/`. | ||
|
|
||
| Accept correctness and security fixes to existing behavior. Require focused regression coverage for an accepted JSEP | ||
| fix. | ||
|
|
||
| For a JSEP WebGPU kernel fix, inspect the corresponding native WebGPU EP implementation. Report an actionable finding | ||
| if the same defect applies there but the change does not include the native fix and focused regression coverage. | ||
|
|
||
| Accept deprecation, migration, or removal work. Read and follow | ||
| [`docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md`](../../docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| description: "Review guidance for maintenance and removal of the deprecated onnxruntime-web WebGL backend." | ||
| applyTo: "js/web/lib/onnxjs/backends/webgl/**,js/web/lib/onnxjs/backends/backend-webgl.ts,js/web/lib/backend-onnxjs.ts,js/web/test/unittests/backends/webgl/**,js/web/test/e2e/browser-test-webgl.js,js/web/script/generate-webgl-operator-md.ts,js/web/docs/webgl-operators.md" | ||
|
edgchen1 marked this conversation as resolved.
|
||
| --- | ||
|
|
||
| # Deprecated WebGL Backend | ||
|
|
||
| The onnxruntime-web WebGL backend is deprecated and scheduled for removal. | ||
|
|
||
| ## Review Policy | ||
|
|
||
| Report changes that expand the WebGL backend with new operators, features, or performance work. Direct new GPU work | ||
| to WebGPU and users who cannot use WebGPU to the WASM/CPU backend. | ||
|
|
||
| Accept correctness and security fixes to existing behavior. Require focused regression coverage for an accepted WebGL | ||
| backend fix. | ||
|
|
||
| Accept deprecation and removal work. Read and follow | ||
| [`docs/design/onnxruntime_web_remove_webgl_backend.md`](../../docs/design/onnxruntime_web_remove_webgl_backend.md). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.