Add review guidance for deprecated components - #32620
Merged
Edward Chen (edgchen1) merged 2 commits intoSep 17, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The WebGL scope omits deprecated implementation paths, and JSEP policy duplication risks documentation drift.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds path-scoped review guidance for deprecated components.
Changes:
- Adds WebGL and JSEP maintenance/removal policies.
- Adds ACL EP deprecation guidance.
File summaries
| File | Description |
|---|---|
.github/instructions/webgl-deprecated.instructions.md |
Defines WebGL review policy. |
.github/instructions/jsep-deprecated.instructions.md |
Defines JSEP review policy. |
.github/instructions/acl-deprecated.instructions.md |
Defines ACL EP review policy. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Jiajia Qin (qjia7)
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The JSEP scope omits central files controlling its runtime and build integration.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
.github/instructions/jsep-deprecated.instructions.md:3
- The scope omits central JSEP integration files, so this policy will not load for changes that alter JSEP selection or prolong its build wiring. For example,
js/web/script/build.ts:57-84selects JSEP versus the native WebGPU EP, andcmake/onnxruntime_webassembly.cmake:219-251adds JSEP exports andpre-jsep.js; both are explicitly part of the migration path but are outsideapplyTo. Add these files (and the other shared runtime integration files that own JSEP-specific branches) to the scope so such PRs receive this guidance.
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Contributor
Author
the intent is to flag new development on JSEP. I think we don't need to include shared files in the |
Edward Chen (edgchen1)
deleted the
edgchen1/deprecation_agent_instructions
branch
September 17, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add agent review guidance for deprecated components.
Motivation and Context
Instruct agent reviewer to direct PRs away from updating deprecated components.