Skip to content

fix: make auth Bearer scheme match case-insensitive (RFC 9110) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonbaldie merged 1 commit into from
Aug 31, 2026
Merged

fix: make auth Bearer scheme match case-insensitive (RFC 9110) #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ export function withAuth(apiToken: string): Middleware {
return next(request, info);
}
const authHeader = request.headers.get("Authorization");
if (!authHeader || authHeader !== `Bearer ${apiToken}`) {
const [scheme, ...rest] = (authHeader ?? "").split(" ");
const token = rest.join(" ");
if (!scheme || scheme.toLowerCase() !== "bearer" || token !== apiToken) {
return new Response("Unauthorized", { status: 401 });
}
return next(request, info);
Expand Down
10 changes: 10 additions & 0 deletions tests/handler_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,16 @@ Deno.test("response body: unauthorized returns 'Unauthorized'", async () => {
assertEquals(await res.text(), "Unauthorized");
});

Deno.test("auth: scheme name is case-insensitive per RFC 9110", async () => {
const handler = makeHandler();
for (const scheme of ["bearer", "BEARER", "BeArEr"]) {
const res = await handler(new Request("http://localhost/queues", {
headers: { "Authorization": `${scheme} ${API_TOKEN}` },
}));
assertEquals(res.status, 200, `scheme "${scheme}" should authenticate`);
}
});

Deno.test("response body: rate limited returns 'Too many requests'", async () => {
const handler = makeHandler(undefined, undefined, 1);
await handler(new Request("http://localhost/length/q", { headers: auth }));
Expand Down