fix: make auth Bearer scheme match case-insensitive (RFC 9110) - #69
Merged
Conversation
Parses the Authorization header into scheme and token instead of comparing the whole header against a fixed-case literal, so bearer, BEARER, etc. authenticate the same as Bearer. Fixes #66 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q25veeccRvgA5zjp6Fhijq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
Auth middleware compared the entire
Authorizationheader against a fixed-caseBearer ${token}literal, rejecting standards-compliant clients that sendbearer/BEARER/etc. (RFC 9110 §11.5 requires the scheme name be case-insensitive; this service's ownopenapi.yamldeclaresscheme: bearer, lowercase).Now splits the header into scheme + token and compares the scheme case-insensitively; token comparison is unchanged (case-sensitive, exact match).
Verified: reproduced 401 on
bearer/BEARER/BeArEragainst the old code, wrote a regression test asserting 200 for all three, confirmed it failed before the fix and passes after. Full test suite (217 tests) green.🤖 Generated with Claude Code