fix(activemq): add in-VM user credentials to simpleAuthenticationPlugin + ConnectionFactory

[natechadwick-intsof]

Summary

Adds credentials to the in-VM ActiveMQConnectionFactory (in both perc-mq.xml and ear/WEB-INF/jetty-env.xml) and a matching user to the simpleAuthenticationPlugin in activemq.xml, so the in-VM JMS connection can authenticate against the T2.2-hardened broker. Without this, every JMS listener gets User name [null] or password is invalid and retries in a 5-second loop.

Why this is needed

The T2.2 PR (#166/#167) set <simpleAuthenticationPlugin anonymousAccessAllowed="false"/> but did not add any users and did not update the in-VM ActiveMQConnectionFactory configurations. The in-VM transport (vm://localhost) sends anonymous (no creds) connections by default, so the broker rejects every connection attempt:

WARN  [org.apache.activemq.broker.TransportConnection] Failed to add Connection ...
  due to User name [null] or password is invalid.
ERROR [org.springframework.jms.listener.DefaultMessageListenerContainer]
  Could not refresh JMS Connection for destination 'queue://PERCUSSION.EMAIL'
  - retrying using FixedBackOff{interval=5000, currentAttempts=37, maxAttempts=unlimited}.
  Cause: User name [null] or password is invalid.

currentAttempts=37 after ~3 minutes is what the user is seeing.

Diff

activemq.xml:

       <plugins>
-          <simpleAuthenticationPlugin anonymousAccessAllowed="false"/>
+          <simpleAuthenticationPlugin
+              anonymousAccessAllowed="false"
+              userPasswords="rhythmyx=rhythmyx"
+              userGroups="rhythmyx=users,admins"/>
       </plugins>

perc-mq.xml and ear/WEB-INF/jetty-env.xml:

      <New class="org.apache.activemq.ActiveMQConnectionFactory">
        <Arg>vm://localhost?brokerConfig=xbean:activemq.xml</Arg>
+       <Set name="userName"><Property name="activemq.username" default="rhythmyx"/></Set>
+       <Set name="password"><Property name="activemq.password" default="rhythmyx"/></Set>
     </New>

Security posture

The T2.2 hardening intent ("auth in place so a future network listener inherits the secure defaults") is preserved:

• anonymousAccessAllowed="false" — anonymous connections are still rejected.
• The default SimpleAuthorizationMap (no explicit <simpleAuthorizationMap>) allows the rhythmyx user in users,admins groups to read/write/admin on all destinations. This is the same effective policy as before the hardening for the in-VM case.
• The default password (rhythmyx) is a placeholder. Operators opening a network listener MUST change it (and add a per-listener user) before adding any <transportConnector>. The comment in activemq.xml points at this requirement.
• The connection factory reads userName and password from system properties (activemq.username, activemq.password) via Jetty's <Property> indirection with rhythmyx defaults — operators can override at install time without rebuilding, e.g. via -Dactivemq.username=... in start.ini.

Depends on #211

This branch is built on top of bugfix/210-activemq-pending-message-limit-strategy (PR #211), which fixes the activemq.xml XSD validity issues. Without #211, the broker can't even start, so this auth fix is moot. After both PRs merge, the in-VM connection should work end-to-end.

Verification

• python3 -c "import xml.etree.ElementTree as ET; ET.parse('activemq.xml')" — well-formed.
• xmllint --schema activemq.xsd activemq.xml --noout — exits 0.
• After deploy + restart:
  • grep "User name" jetty/base/logs/server.log | wc -l → 0
  • The currentAttempts counter on the JMS listener retry messages stops climbing
  • PERCUSSION.EMAIL, PERCUSSION.PUBLISHING, PERCUSSION.NOTIFICATIONS all reach steady state without retry

Refs #212

Co-Authored by Mavis Mavis-Code using MiniMax-M3 with agent mavis.