fix(activemq): use <users>/<authenticationUser> child elements

[natechadwick-intsof]

Summary

The activemq.xsd says userPasswords and userGroups are xs:string attributes on <simpleAuthenticationPlugin>, but the actual SimpleAuthenticationPlugin class in 5.16.8 has setters that take Map<String, ...>, not String. There is no custom property editor registered, so Spring's BeanWrapper rejects the bean init with ConversionNotSupportedException. The fix is to use the <users> / <authenticationUser> child-element pattern that the same XSD declares, and that PR #213 should have used originally.

The actual error from the install

ERROR [org.apache.activemq.xbean.XBeanBrokerFactory] Failed to load:
  class path resource [activemq.xml], reason: Error creating bean with name
  'org.apache.activemq.xbean.XBeanBrokerService#...' defined in class path
  resource [activemq.xml]: Cannot create inner bean
  'simpleAuthenticationPlugin#...' ... nested exception is
  org.springframework.beans.ConversionNotSupportedException: Failed to
  convert property value of type 'java.lang.String' to required type
  'java.util.Map' for property 'userGroups': no matching editors or
  conversion strategy found

The XSD is misleading. From javap on the class in activemq-broker-5.16.8.jar:

public void setUserGroups(java.util.Map<java.lang.String, java.util.Set<java.security.Principal>>);
public void setUserPasswords(java.util.Map<java.lang.String, java.lang.String>);

— the XSD's xs:string attribute type is just wrong. The XSD needs a different element form.

The fix

Use the <users> / <authenticationUser> child-element pattern from the same activemq.xsd:

       <plugins>
-          <simpleAuthenticationPlugin
-              anonymousAccessAllowed="false"
-              userPasswords="rhythmyx=rhythmyx"
-              userGroups="rhythmyx=users,admins"/>
+          <simpleAuthenticationPlugin anonymousAccessAllowed="false">
+              <users>
+                  <authenticationUser username="rhythmyx" password="rhythmyx" groups="users,admins"/>
+              </users>
+          </simpleAuthenticationPlugin>
       </plugins>

<authenticationUser> is the helper class org.apache.activemq.security.AuthenticationUser (3-arg String constructor and matching setters), declared in activemq.xsd as a child of the plugin's <users> element. XBean/Spring constructs the List<AuthenticationUser> from the child elements and passes it to setUsers(List<?>).

The perc-mq.xml and ear/WEB-INF/jetty-env.xml changes from PR #213 are unchanged — the broker just needs the user expressed in a form it can actually parse.

Why the XSD is wrong

Looking at the activemq.xsd in 5.16.8, both forms are declared:

<xs:element name='simpleAuthenticationPlugin'>
  <xs:complexType>
    <xs:choice minOccurs="0" maxOccurs="unbounded">
      <xs:element name='userGroups' .../>
      <xs:element name='userPasswords' .../>
      <xs:element name='users' .../>
      ...
    </xs:choice>
    <xs:attribute name='userPasswords' type='xs:string'/>  <!-- lies -->
    <xs:attribute name='userGroups' type='xs:string'/>      <!-- lies -->
    ...
  </xs:complexType>
</xs:element>

The attributes are declared as xs:string but the corresponding Java setters take Map. There is no XBean custom editor to bridge the two. The attribute form is documented as supported but isn't actually implemented in 5.16.8. The child-element form (<users> / <authenticationUser>) is the one that actually works.

Verification

• python3 -c "import xml.etree.ElementTree as ET; ET.parse('activemq.xml')" — well-formed.
• xmllint --schema activemq.xsd activemq.xml --noout — exits 0.
• After deploy + restart:
  • grep -c "Failed to convert property value" jetty/base/logs/server.log — 0
  • grep -c "Failed to load: class path resource \[activemq.xml\]" ... — 0
  • grep -c "User name \[null\] or password is invalid" ... — 0
  • JMS listeners reach steady state without retry.

Refs #214

Co-Authored by Mavis Mavis-Code using MiniMax-M3 with agent mavis.