Skip to content

fix(calendar): PSCalendarMonthModel.getEvents returns null per documented contract #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natechadwick-intsof merged 1 commit into from
Sep 8, 2026
Merged

fix(calendar): PSCalendarMonthModel.getEvents returns null per documented contract #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...xtensions-sfp/src/main/java/com/percussion/fastforward/calendar/PSCalendarMonthModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,16 @@ public String getEnd() {
* Gets the events that occur on the specified day of the month.
*
* @param day day of the month whose events will be returned
* @return a collection of assembled events for the specified day. will be <code>null</code> if no
* events have been set or events occur on the specified day
* @return a collection of assembled events for the specified day, never empty. Will be <code>
* null</code> if no events have been set or no events occur on the specified day.
*/
public Collection<IPSAssemblyResult> getEvents(int day) {
if (getModel().m_eventsByDay == null) {
return null;
} else {
return (Collection<IPSAssemblyResult>) getModel().m_eventsByDay.get(day);
}
Collection<IPSAssemblyResult> events =
(Collection<IPSAssemblyResult>) getModel().m_eventsByDay.get(day);
return (events == null || events.isEmpty()) ? null : events;
}

/**
Expand Down
Loading