fix(calendar): PSCalendarMonthModel.getEvents returns null per documented contract

[natechadwick-intsof]

Summary

PSCalendarMonthModel.getEvents(int) did not honor its documented contract: when setEvents(...) was called with a non-empty list and the requested day had no events, the method returned an empty collection instead of null. This caused PSCalendarMonthModelTest.testEmptyEvents to fail with expected null, but was:<[]>.

The fix normalizes the return value in getEvents itself (so an empty result becomes null) and corrects the JavaDoc, which had a typo where the "no" was missing before "events occur on the specified day".

Root cause

The JavaDoc reads:

"will be null if no events have been set or events occur on the specified day"

The second clause is nonsensical as a null condition. The intended meaning (corroborated by the @Ignored testEvents test which has assertNull(m_info.getEvents(1)) after setEvents(events)) is:

"will be null if no events have been set or no events occur on the specified day"

Changes

• modules/extensions-sfp/src/main/java/com/percussion/fastforward/calendar/PSCalendarMonthModel.java
  • getEvents(int): when m_eventsByDay is non-null, also return null if the per-day collection is empty.
  • JavaDoc: fix typo, add "never empty" guarantee.

Testing

./mvn-env.sh test -Dtest=PSCalendarMonthModelTest -pl modules/extensions-sfp

Result: Tests run: 9, Failures: 0, Errors: 0, Skipped: 1 (the skipped test is the pre-existing @Ignored testEvents, which has separate issues unrelated to this fix).

Linked issue

Closes #197

Co-Authored by MiniMax Code 1.0 using MiniMax-M3 with agent mavis.