Skip to content

[fix-finder] Remove stale AIDL byte FIXMEs #12671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Sep 4, 2026
Merged

[fix-finder] Remove stale AIDL byte FIXMEs #12671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4135c83
Remove stale AIDL byte FIXMEs
github-actions[bot] Sep 4, 2026
c52408c
Preserve AIDL generator whitespace
github-actions[bot] Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Xamarin.Android.Tools.Aidl/CSharpCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,6 @@ string GetCreateStatements (TypeName type, string parcel, string arg)
return String.Format ("{0} = {1}.ReadInt () != 0;", arg, parcel);
case "bool []":
return String.Format ("{0} = {1}.CreateBooleanArray ();", arg, parcel);
// FIXME: I'm not sure if aidl should support byte...
case "sbyte":
return String.Format ("{0} = {1}.ReadByte ();", arg, parcel);
case "byte []":
Expand Down Expand Up @@ -501,7 +500,6 @@ string GetReadStatements (TypeName type, string parcel, string arg)
return String.Format ("{1}.ReadStringArray ({0});", arg, parcel);
case "bool []":
return String.Format ("{1}.ReadBooleanArray ({0});", arg, parcel);
// FIXME: I'm not sure if aidl should support byte...
case "byte []":
return String.Format ("{1}.ReadByteArray ({0});", arg, parcel);
case "char []":
Expand Down Expand Up @@ -565,7 +563,6 @@ string GetWriteStatements (TypeName type, string parcel, string arg, string parc
return parcel + ".WriteInt (" + arg + " ? 1 : 0);";
case "bool []":
return parcel + ".WriteBooleanArray (" + arg + ");";
// FIXME: I'm not sure if aidl should support byte...
case "sbyte":
return parcel + ".WriteByte (" + arg + ");";
case "byte []":
Expand Down Expand Up @@ -683,4 +680,3 @@ string JoinArguments (Method m)
}
}
}