[fix-finder] Remove stale AIDL byte FIXMEs - #12671
Merged
jonathanpeppers merged 2 commits intoSep 4, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 4, 2026 02:02
jonathanpeppers
approved these changes
Sep 4, 2026
jonathanpeppers
deleted the
nightly/remove-stale-aidl-byte-fixme-2fd7a0e2d12cd568
branch
September 4, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CSharpCodeGenerator.cscontained three 2016-era FIXME comments questioning whether AIDL supportsbyte. AIDL supports thebyteprimitive, and the generator already maps it to C#sbytewhile implementing scalar and array parcel reads and writes, so the comments were stale and misleading.Fix
Removed the three obsolete byte-support FIXME comments from
src/Xamarin.Android.Tools.Aidl/CSharpCodeGenerator.cs. No generator behavior changed.Validation
MSBUILD_ARGS='-p:AndroidSdkDirectory=/home/runner/work/android/android/bin/Debug/android-sdk -p:AndroidNdkDirectory=/home/runner/work/android/android/bin/Debug/android-ndk' ./build.sh Prepare— succeeded with 0 warnings and 0 errors../dotnet-local.sh build src/Xamarin.Android.Tools.Aidl/Xamarin.Android.Tools.Aidl.csproj— succeeded with 0 warnings and 0 errors.Fix-finder metadata
00-todo-fixme-hack29/30(actionability:9, safety:10, scope:10)