fix(go2): record camera calibration - #3748
Conversation
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Greptile SummaryAdds T-Rex validation blockedThe focused blueprint-construction check could not import the Go2 blueprints because the Python package Confidence Score: 5/5No product defect was established in the changed recorder declarations. The final review contains no confirmed finding. Static inspection shows both recorder inputs use the same unremapped Files Needing Attention: No source file requires a corrective change. Restore the complete Python runtime dependency set before running the focused Go2 blueprint wiring check.
What T-Rex did
|
Contribution path
Problem
Go2 recordings include camera images but omit the corresponding
CameraInfostream.Consumers therefore need a local calibration file or internal
GO2Connection.camera_info_staticknowledge to interpret images, so exported recordings are not self-contained.Solution
Add a typed
camera_infoinput to both Go2 recorder variants:Go2MemoryandGo2Mid360Recorder.How to Test
uv run pytest dimos/robot/unitree/go2/test_recorders.py -qAlso validated the neighboring Go2 blueprint tests, blueprint registry generation, focused mypy/ruff checks, and
pre-commit run --all-files.AI assistance
OpenCode with GPT-5.6 Sol implemented the change, added the regression test, ran validation, and prepared this draft PR under human direction.
Checklist