/source --special flag, allowing special /commands from an allowlist - #2151
Merged
Conversation
from an allowlist. In release v2.12.0, /source scripts were disallowed from running special commands, as part of a fix to the bug in which /source read the entire script into memory. This seemed like a good call, because some special commands such as /edit might lock up outside of the REPL, and other special commands such as /source itself raise the question of recursion. However, after a bug report, this change restores the ability to run special commands in side a /source'd script, but only those special commands deemed to be safe in that context, and not by default: the --special flag must be given to /source. /favorite queries are also not allowed to recurse into special commands.
rolandwalker
force-pushed
the
RW/source-special-flag
branch
from
August 22, 2026 12:39
b63755f to
2359726
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In release v2.12.0,
/sourcescripts were disallowed from running special commands, as part of a fix to the bug in which/sourceread the entire script into memory.This seemed like a good call, because some special commands such as
/editmight lock up outside of the REPL, and other special commands such as/sourceitself raise the question of recursion.However, after a bug report, this change restores the ability to run special commands in side a
/source'd script, but only those special commands deemed to be safe in that context, and not by default: the--specialflag must be given to/source./favoritequeries are also not allowed to recurse into special commands.Fixes #2148, though we still need a followup for the specific issue of exiting without a warning when
/sourceis combined with--execute.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).