Exit on error for --execute containing /source - #2152
Merged
Conversation
If a /source'd file contains a special command, and the --special flag was not given to /source, then --execute should be able to print an error message to the stderr and exit with an exit code. The error message was previously visible only at the REPL. This requires adding an is_error property to SQLResult, which may be useful in other contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a
/source'd file contains a special command, and the--specialflag was not given to/source, then--executeshould be able to print an error message to the stderr and exit with an exit code.The error message was previously visible only at the REPL.
This requires adding an
is_errorproperty toSQLResult, which may be useful in other contexts.This is strictly the fix for the report in #2148 .
xref #2151.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).