Skip to content

Wait for HLS to index before hovering an identifier from base #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasjm merged 1 commit into from
Aug 27, 2026
Merged

Wait for HLS to index before hovering an identifier from base #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/app/Spec/Tests/Haskell/Hover.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import Language.LSP.Test hiding (message)
import qualified Language.LSP.Test.Helpers as Helpers
import Spec.Tests.Haskell.Common
import Test.Sandwich as Sandwich
import Test.Sandwich.Waits
import TestLib.LSP
import TestLib.Types

Expand All @@ -23,12 +24,15 @@ tests = describe "Hover" $ do
allHoverText hover `textShouldContain` [i|foo|]
allHoverText hover `textShouldContain` [i|main.ipynb.hs:1:1|]

-- Unlike foo, putStrLn comes from base, so there's no hover until HLS has indexed
-- the dependencies.
it "hovers putStrLn" $ doNotebookSession lsName hoverCode $ \(Helpers.LspSessionInfo {..}) -> do
ident <- openDoc lspSessionInfoFileName "haskell"
hover <- getHoverOrException ident (Position 1 1)
(hover ^. range) `shouldBe` Just (Range (Position 1 0) (Position 1 8))
let InL (MarkupContent {..}) = hover ^. contents
_value `textShouldContain` "putStrLn :: String -> IO ()"
waitUntil 120 $ do
hover <- getHoverOrException ident (Position 1 1)
(hover ^. range) `shouldBe` Just (Range (Position 1 0) (Position 1 8))
let InL (MarkupContent {..}) = hover ^. contents
_value `textShouldContain` "putStrLn :: String -> IO ()"

hoverCode :: Text
hoverCode = [__i|foo = "hello"
Expand Down
Loading