Wait for HLS to index before hovering an identifier from base - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hovers putStrLnfails intermittently withNo hover returned.— onmaintoday, not just onbranches.
hovers fooin the same file never fails:foois a local binding,putStrLnis frombaseand has no hover until HLS has indexed dependencies. The test hovers immediately afteropenDoc, so it races that.Wrapped in
waitUntil, which retries until the assertions hold.I looked at waiting on work-done progress (
$/progress, whichlsp-testalready tracks viagetIncompleteProgressSessions) instead. It isn't sound: an empty progress set doesn't distinguish"finished" from "between tasks", so the check can land in the gap before the server starts more
work. Retrying the assertion is the thing that actually converges.
Compiles; the flake itself only reproduces under CI load.