Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
WORKFLOW_PATH = (
Path(__file__).parents[2] / "workflows" / "opentelemetry-conformance-tests.yml"
)
ORCHESTRATOR_REVISION = "8de1bbfdccfeb36d5f9ccee99f21533f0bcb1d72"
ORCHESTRATOR_REVISION = "91740c98b496409fa9f1bb8e8e6c329ca8b0185f"
EXAMPLES_DIR = (
".build/durable-sdk/packages/aws-durable-execution-sdk-python-conformance-tests-otel"
)
Expand All @@ -13,6 +13,8 @@
def test_opentelemetry_conformance_caller_uses_current_workflow_contract() -> None:
workflow = WORKFLOW_PATH.read_text()

assert ' schedule:\n - cron: "0 7 * * *"' in workflow

orchestrator = (
"uses: aws/aws-durable-execution-conformance-tests/.github/workflows/"
f"opentelemetry-orchestrator.yml@{ORCHESTRATOR_REVISION}"
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/opentelemetry-conformance-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ on:
- "packages/aws-durable-execution-sdk-python-otel/**"
- "packages/aws-durable-execution-sdk-python-conformance-tests-otel/**"
- ".github/workflows/opentelemetry-conformance-tests.yml"
schedule:
- cron: "0 7 * * *"
Comment thread
ayushiahjolia marked this conversation as resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review

[P2] Move the schedule off minute zero

GitHub may delay or drop scheduled runs during the high-load start-of-hour window. A dropped run here skips the automatic check/launch cycle for a full day. Use a non-zero minute, as the repository already does for other schedules, and update the test assertion accordingly.

workflow_dispatch:
inputs:
phase:
Expand Down Expand Up @@ -56,7 +58,7 @@ jobs:
actions: write
contents: read
id-token: write
uses: aws/aws-durable-execution-conformance-tests/.github/workflows/opentelemetry-orchestrator.yml@8de1bbfdccfeb36d5f9ccee99f21533f0bcb1d72
uses: aws/aws-durable-execution-conformance-tests/.github/workflows/opentelemetry-orchestrator.yml@91740c98b496409fa9f1bb8e8e6c329ca8b0185f
with:
language: python
resource_prefix: p
Expand Down
Loading