Skip to content

ci: schedule long-running OTel conformance tests - #665

Open
zhongkechen wants to merge 2 commits into
mainfrom
otel-long-running-schedule
Open

ci: schedule long-running OTel conformance tests#665
zhongkechen wants to merge 2 commits into
mainfrom
otel-long-running-schedule

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore the daily 07:00 UTC trigger from the former shared Python OpenTelemetry workflow
  • let scheduled events drive the reusable orchestrator's automatic long-running check/launch cycle
  • cover the schedule in the existing workflow contract test

Related issue: aws/aws-durable-execution-conformance-tests#90

Related PRs:

Testing

  • executed test_opentelemetry_conformance_caller_uses_current_workflow_contract directly
  • parsed .github/workflows/opentelemetry-conformance-tests.yml successfully with Ruby YAML
  • git diff --check

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 20, 2026 19:43 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 20, 2026 19:43 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

Claude AI review

No actionable findings.

This PR adds a daily schedule trigger (cron: "0 7 * * *") to .github/workflows/opentelemetry-conformance-tests.yml and extends the existing contract test with a matching substring assertion. Both changes are correct:

  • The new test assertion ' schedule:\n - cron: "0 7 * * *"' matches the YAML indentation exactly (2-space schedule:, 4-space - cron:), so test_opentelemetry_conformance_caller_uses_current_workflow_contract will pass.
  • On a schedule event the inputs.* context is empty, so the ${{ inputs.X || 'default' }} fallbacks (phase: short, delay_seconds: 82800, aws_region: us-west-2, conformance_test_ref: main) resolve cleanly, and sdk_ref correctly falls back to github.sha (default-branch head) since there is no pull_request payload.
  • Omitting a paths filter under schedule is correct (GitHub does not support path filters on scheduled events).

Residual test risk: The PR's stated intent — that scheduled events "drive the reusable orchestrator's automatic long-running check/launch cycle" — depends on the external aws/aws-durable-execution-conformance-tests orchestrator inspecting github.event_name == 'schedule' rather than the phase input (which resolves to short on cron runs). That behavior lives outside this repo and cannot be verified from this diff; the contract test only asserts the caller's YAML text, not the end-to-end schedule-driven behavior.

Reviewed commit fc0bd2120779fed9b13e2cafe4d3d9f44c078e46. Workflow run

- "packages/aws-durable-execution-sdk-python-conformance-tests-otel/**"
- ".github/workflows/opentelemetry-conformance-tests.yml"
schedule:
- cron: "0 7 * * *"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review

[P2] GitHub warns that workflows scheduled at the start of an hour may be delayed or dropped under load; this repository already avoids :00 for that reason in stale-issue-closer.yml. A dropped run skips the long-running check/launch cycle for the day. Use a nonzero minute, such as 7 7 * * *, and update the corresponding test assertion.

@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

One reliability issue: the daily schedule uses GitHub's peak-load minute. The contract test only validates workflow text, not scheduled execution.

Reviewed commit fc0bd2120779fed9b13e2cafe4d3d9f44c078e46. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant