Skip to content

_sourcetests: Do not assume Source.ref is a string #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abderrahim merged 1 commit into from
Sep 2, 2026
+3 −3
Merged

_sourcetests: Do not assume Source.ref is a string #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/buildstream/_testing/_sourcetests/mirror.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def test_mirror_track_upstream_present(cli, tmpdir, datafiles, kind):
new_element = _yaml.load(element_path, shortname=element_name)
source = new_element.get_sequence("sources").mapping_at(0)
if "ref" in source:
assert source.get_str("ref") == upstream_ref
assert source.get_node("ref").strip_node_info() == upstream_ref


@pytest.mark.datafiles(DATA_DIR)
Expand Down Expand Up @@ -293,4 +293,4 @@ def test_mirror_track_upstream_absent(cli, tmpdir, datafiles, kind):
new_element = _yaml.load(element_path, shortname=element_name)
source = new_element.get_sequence("sources").mapping_at(0)
if "ref" in source:
assert source.get_str("ref") == mirror_ref
assert source.get_node("ref").strip_node_info() == mirror_ref
2 changes: 1 addition & 1 deletion src/buildstream/_testing/_sourcetests/track.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def test_track_include(cli, tmpdir, datafiles, ref_storage, kind):
# Get the first source from the sources list
new_source = sources_list.mapping_at(0)
assert "ref" in new_source
assert ref == new_source.get_str("ref")
assert ref == new_source.get_node("ref").strip_node_info()


@pytest.mark.datafiles(DATA_DIR)
Expand Down
Loading