_sourcetests: Do not assume Source.ref is a string - #2187
Merged
Conversation
aleixpol
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
September 2, 2026 00:15
abderrahim
approved these changes
Sep 2, 2026
abderrahim
left a comment
abderrahim
left a comment
Contributor
There was a problem hiding this comment.
Please add a _sourcetests: prefix to your commit message. It looks weird without it.
types.py specifies as: SourceRef = Union[None, int, str, List[Any], Dict[str, Any]]
aleixpol
force-pushed
the
aleixpol/refs-not-strings
branch
from
September 2, 2026 09:14
2387a22 to
1a2869f
Compare
aleixpol
changed the title
Contributor
Author
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types.py specifies as:
SourceRef = Union[None, int, str, List[Any], Dict[str, Any]]