Feat/player time edit - #539
Open
azfoo wants to merge 3 commits into
Open
Conversation
azfoo
marked this pull request as ready for review
May 19, 2026 13:48
Comment on lines
+228
to
+232
| try: | ||
| current_time = get(Get.MEDIA_CURRENT_TIME) | ||
| except NoReplyToRequest: | ||
| current_time = None | ||
| settings.update_recent_files(path, geometry, window_state, time=current_time) |
Collaborator
There was a problem hiding this comment.
What does this fix? Consider adding comment.
- static "MM:SS / MM:SS" label is replaced by an editable QLineEdit that lets users seek by typing a time and pressing Enter. Escape reverts the edit without seeking. QRegularExpressionValidator allows partial input while typing. - controls are now disabled individually rather than via setEnabled() on the whole toolbar, so the time edit and duration label can remain enabled in the NO_MEDIA state when a duration is present (e.g. annotation-only files with no media loaded). - current playback position is saved to recent-file settings on save and restored as a pending seek when the file is next opened. YouTube files are excluded since autoplay is disabled and seeking before the player is able to play doesn't do anything.
azfoo
force-pushed
the
feat/player-time-edit
branch
from
August 24, 2026 18:52
5f3fb97 to
9ed526c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player time display is now a seekable input; playback position restored on file open
QLineEdit.Type a time in
HH:MM:SS.f,MM:SS.f, or plain-seconds format and press Enter to seek; the value is clamped to[0, duration].Pressing Escape reverts without seeking.
The field is not updated while it has focus so in-progress edits survive playback ticks.
A
QRegularExpressionValidatorallows all intermediate states while typing.setEnabled()on the whole toolbar, sotime_editand the duration label remain enabled inNO_MEDIAstate when a duration is present (annotation-only files with no media loaded).parse_media_time()as the inverse offormat_media_time().(somewhat resolves #378)