Fixed width for time label - #572
Closed
minamouse wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks! This has bothered me for the longest time, but not quite enough so I would do something about it. The fix would have been good, but this is already contained in #539, which changes the label to an editable input. I am closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a fixed width for the time label based on the total time duration string (plus a buffer width).
Previously, as the current time string was updated, the entire player bar would shift slightly. This creates a fixed width so the other icons don't move.
Test plan
Load a file and press play.
Before:
before.mov
After
after.mov