Skip to content

fix(commandxlat): Consume the cheat and demo messages consistently when handled #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bas-slats wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(commandxlat): Consume the cheat and demo messages consistently when handled #3138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Core/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3677,6 +3677,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
Money *money = localPlayer->getMoney();
money->deposit( 10000 );
TheInGameUI->messageNoFormat( TheGameText->FETCH_OR_SUBSTITUTE("GUI:DebugAddCash", L"Add Cash") );

disp = DESTROY_MESSAGE;
}
break;
}
Expand Down Expand Up @@ -3717,6 +3719,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
TheInGameUI->messageNoFormat( TheGameText->FETCH_OR_SUBSTITUTE("GUI:DebugObjectHealthOn", L"Object Health is ON") );
else
TheInGameUI->messageNoFormat( TheGameText->FETCH_OR_SUBSTITUTE("GUI:DebugObjectHealthOff", L"Object Health is OFF") );

disp = DESTROY_MESSAGE;
}
break;

Expand Down Expand Up @@ -4860,6 +4864,7 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
case GameMessage::MSG_META_DEMO_TOGGLE_RENDER:
{
TheWritableGlobalData->m_disableRender = !TheGlobalData->m_disableRender;
disp = DESTROY_MESSAGE;
break;
}

Expand All @@ -4873,6 +4878,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
Money *money = localPlayer->getMoney();
money->deposit( 10000 );
TheInGameUI->messageNoFormat( TheGameText->FETCH_OR_SUBSTITUTE("GUI:DebugAddCash", L"Add Cash") );

disp = DESTROY_MESSAGE;
}
break;
}
Expand Down Expand Up @@ -4913,6 +4920,7 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
obj->kill();
}
}
disp = DESTROY_MESSAGE;

@Skyaero42 Skyaero42 Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: white line after closing bracket.
Two times in this file.

@xezon xezon Aug 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe only destroy if something was killed? Not sure if that makes sense.

}
break;

Expand Down Expand Up @@ -5006,6 +5014,7 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
} else {
TheDisplay->setDebugDisplayCallback(nullptr);
}
disp = DESTROY_MESSAGE;
break;
}
#endif // #ifdef PERF_TIMERS
Expand Down Expand Up @@ -5589,6 +5598,7 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage

TheInGameUI->messageNoFormat( TheGameText->FETCH_OR_SUBSTITUTE_FORMAT("GUI:DebugPerformStatisticalDump",
L"Statistics dump made on frame: %d", TheGameLogic->getFrame() ) );
disp = DESTROY_MESSAGE;
break;
#endif // DUMP_PERF_STATS

Expand Down
Loading