Skip to content

Apply conservative fixes for common DAYamlChecker findings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonprofittechy merged 1 commit into from
Sep 15, 2026
+5 −3
Merged

Apply conservative fixes for common DAYamlChecker findings #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docassemble/EnlargeTimeToFile/data/questions/motion_to_enlarge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
---
code: |
def get_pronouns(person):
if person.pronouns.all_false():

Check warning on line 142 in docassemble/EnlargeTimeToFile/data/questions/motion_to_enlarge.yml

View workflow job for this annotation

GitHub Actions / build

WG123 

code block defines function `get_pronouns`; move reusable helper functions to a Python module instead, or use inline code for small snippets that are only used once
return {"Prefer not to say"}
pronouns = set(person.pronouns.true_values()) - {'self-described'}
if person.pronouns.get("self-described"):
Expand Down Expand Up @@ -217,7 +217,9 @@
Have you filed your docketing statement?
subquestion: |
Each appellant or cross-appellant, other than a self-represented litigant who is incarcerated, is required to submit the docketing statement within fourteen days of issuance of the notice of entry of the appeal.
yesno: docketing_statement
fields:
- no label: docketing_statement
datatype: yesnoradio
---
id: warning
event: docketing_warning
Expand Down Expand Up @@ -308,9 +310,9 @@
- I need more time to work on my brief: I need more time to work on my brief
none of the above: False
required: False
- Other: has_other_reason

Check warning on line 313 in docassemble/EnlargeTimeToFile/data/questions/motion_to_enlarge.yml

View workflow job for this annotation

GitHub Actions / build

WA512 

field label may be too vague for assistive technology users: Other
datatype: yesnowide
- Other: other_reason_for_extension

Check warning on line 315 in docassemble/EnlargeTimeToFile/data/questions/motion_to_enlarge.yml

View workflow job for this annotation

GitHub Actions / build

WA512 

field label may be too vague for assistive technology users: Other
show if: has_other_reason
validation code: |
if reason_additional_time.all_false() and not has_other_reason:
Expand Down Expand Up @@ -378,7 +380,7 @@
${x}
progress: 99
---
id: signature date
id: "signature date 2"
question: |
When do you plan to file these forms that we are working on?
subquestion: |
Expand Down
2 changes: 1 addition & 1 deletion docassemble/EnlargeTimeToFile/data/questions/old_mavc_appeals_basic_questions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
to the court on your own.
% endif

Tap the {green words} in any screen for a definition or more information.

Check warning on line 25 in docassemble/EnlargeTimeToFile/data/questions/old_mavc_appeals_basic_questions.yml

View workflow job for this annotation

GitHub Actions / build

WA516 

text in subquestion may rely on color or symbols alone to convey meaning: % if form_approved_for_email_filing: The MassAccess Project can help you complete and file court forms in 3 steps: % el…

If you have questions about this form or the court process,
call the Appeals Court Clerk's Office:
Expand Down Expand Up @@ -164,7 +164,7 @@

Press below to deliver the form.
fields:
- no label: acknowledge_email_notices
- "Final Review With Cover Page": acknowledge_email_notices
datatype: checkboxes
choices:
- I understand that I will get notices from the court by email
Expand Down
Loading