Skip to content

Apply conservative fixes for common DAYamlChecker findings - #34

Merged
nonprofittechy merged 1 commit into
mainfrom
turbolift-yaml-fixer-final2
Sep 15, 2026
Merged

nonprofittechy merged 1 commit into
mainfrom
turbolift-yaml-fixer-final2

Conversation

@nonprofittechy

Copy link
Copy Markdown
Member

This PR applies the deterministic fixer from DAYamlChecker PR #85 to this repository's YAML interviews.

The fixer makes only these mechanical changes:

  • adds question IDs derived from question text, with numeric suffixes for duplicates;
  • expands yesno/noyes shortcuts to fields with datatype: yesnoradio;
  • expands yesnomaybe/noyesmaybe while preserving datatype: yesnomaybe;
  • labels only the first offending field on a multi-field screen; and
  • suffixes later duplicate block IDs, including block-scalar IDs.

The fixer validates each candidate YAML before writing it and is idempotent. Additional unlabeled fields are intentionally left for human review when the first-field heuristic cannot safely resolve the screen.

Validation for the campaign:

  • 42 Turbolift checkouts ran successfully using dayamlchecker --fix;
  • 40 repositories have changes in 85 YAML files;
  • 142 EG414, 113 EA510, 36 EG104, and 68 safe EA502 findings were fixed;
  • 27 residual EA502 findings are intentional later/conditional unlabeled fields;
  • a second --fix pass made no changes in all 42 checkouts; and
  • all changed files pass YAML validation and git diff --check.

Please review the generated labels and IDs in context before merging.

This PR was generated using turbolift.

@nonprofittechy
nonprofittechy marked this pull request as ready for review September 15, 2026 20:14
@nonprofittechy
nonprofittechy merged commit 4d0fe80 into main Sep 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant