Skip to content

docs(fullsend): CI install, dispatch design, and upgrade procedures (TC-6193) - #305

Merged
mrizzi merged 1 commit into
verify-pr-fullsendfrom
TC-6193
Sep 17, 2026
Merged

mrizzi merged 1 commit into
verify-pr-fullsendfrom
TC-6193

Conversation

@mrizzi

@mrizzi mrizzi commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Documents the deployed verify-pr fullsend install and day-2 operations in fullsend.md (TC-6180 Req 16). Docs-only change.

  • CI deployment (per-repo GitHub App) — new section: fullsend github setup, fullsend inference provision (hosted Vertex via WIF), and org GitHub App install.
  • Dispatch design — why pull_request + lewagon/wait-on-check-action (inline CI wait) instead of check_suite/check_run/workflow_run; CI-result-is-data-not-a-gate; the CEL trigger on the composing child; pre_script Jira JQL gating.
  • Variables and secrets (day-2 management) — table of every CI vars.* / secrets.* (incl. the Jira Service Account JIRA_EMAIL / JIRA_API_TOKEN) with how/when to rotate each.
  • Bumping the fullsend version — pin lives in the dispatch workflow (fullsend_version: "v0.43.0"); bump + re-validate procedure.
  • Keeping the two plugin-version files in syncplugin.json + marketplace.json bumped together.
  • Refreshed stale v0.37.0 framing in the intro/prerequisites.

Head branch is on the upstream repo (not the fork) so the verify-pr pull_request dispatch gets secrets + OIDC and can run. Supersedes #304.

Verification

Reviewed for accuracy against the deployed sources: .github/workflows/fullsend-verify-pr.yml, .fullsend/config.yaml, .fullsend/config.base.yaml, .fullsend/harness/verify-pr.yaml, and the two version files. CI checks (CONVENTIONS.md) all green: pytest 147 passed, claude plugin validate ✔, skillsaw 0 errors.

Implements TC-6193

🤖 Generated with Claude Code

Summary by Sourcery

Document the fullsend verify-pr CI deployment, dispatch design, credential rotation, and upgrade procedures.

Enhancements:

  • Document the deployed verify-pr fullsend CI setup, dispatch behavior, Jira gating, and credential management procedures.
  • Document how to update the pinned fullsend CLI version and keep plugin manifest and marketplace versions synchronized.

Documentation:

  • Refresh the fullsend guide with current CLI prerequisites and comprehensive CI deployment and day-2 operational guidance.

…cedures

Add a CI deployment section (per-repo fullsend github setup / inference
provision / org GitHub App install), a dispatch-design section (inline
pull_request wait via lewagon/wait-on-check-action, CEL trigger, pre_script
Jira gating), a day-2 variables/secrets management table, and maintenance
procedures for bumping the pinned fullsend version and keeping the two
plugin-version files in sync. Refresh stale v0.37.0 references.

Implements TC-6193

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Expands fullsend.md with implementation-level documentation for the deployed verify-pr CI setup, event and gating design, operational variable/secret management, CLI and plugin upgrade procedures, and current Jira reporting behavior.

Sequence diagram for the pull request verify-pr dispatch

sequenceDiagram
    participant GitHub
    participant Wait as wait-on-check-action
    participant Dispatch as reusable-dispatch.yml
    participant OIDC
    participant Vertex
    participant Fullsend
    participant Jira

    GitHub->>Wait: pull_request opened/synchronize/reopened
    Wait->>Wait: Wait for other checks to reach terminal state
    Wait-->>Dispatch: Release dispatch after checks or timeout
    Dispatch->>OIDC: Mint review-role App token
    Dispatch->>Vertex: Obtain short-lived WIF credential
    Dispatch->>Fullsend: fullsend run verify-pr
    Fullsend->>Jira: pre_script JQL lookup and status/label gate
    Jira-->>Fullsend: Qualifying issue
    Fullsend->>Jira: post_script report comment
Loading

Flow diagram for CI-result-is-data verify-pr gating

flowchart TD
    A[Pull request event] --> B[Wait for other checks]
    B --> C{Checks terminal?}
    C -->|success, failure, or other terminal result| D[Dispatch verify-pr]
    C -->|no checks| D
    C -->|45-minute timeout| E[Skip dispatch]
    D --> F{Jira issue in Review with ai-generated-jira label?}
    F -->|yes| G[Run sandboxed verify-pr]
    F -->|no| H[Skip agent]
Loading

File-Level Changes

Change Details Files
Document the deployed per-repository CI installation and dispatch architecture for automatic verify-pr reviews.
  • Describe GitHub setup, hosted Vertex provisioning through WIF, and org App installation.
  • Explain the pull-request trigger, inline wait for all terminal CI outcomes, concurrency behavior, reusable workflow dispatch, and child-level CEL trigger.
  • Document Jira pre-script eligibility gating and upstream-repository requirements for secrets and OIDC.
fullsend.md
Add day-2 operational guidance for CI configuration and credential rotation.
  • Catalog GitHub Actions variables and secrets with purposes and update conditions.
  • Explain Jira Service Account credential handling and rotation without code changes.
fullsend.md
Document version upgrade and release synchronization procedures.
  • Replace stale v0.37.0 framing and record the CI pin at v0.43.0.
  • Provide an end-to-end validation procedure for bumping the CLI version.
  • Require synchronized updates to plugin.json and marketplace.json, distinguishing version bumps from harness re-pin and re-lock operations.
fullsend.md
Refresh deployed verification and reporting details to reflect the tier-1 Jira account.
  • Update the verification narrative to identify the configured Jira account as the report-comment author.
  • Retain the upstream-branch and CI outcome context.
fullsend.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 17, 2026

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 10:07 AM UTC · Completed 10:15 AM UTC

Commit: 3c951de · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $4.15

@fullsend-ai-review

Copy link
Copy Markdown

Verification Report for TC-6193 (commit 3c951de)

Check Result Details
Review Feedback N/A No inline comments and no substantive review bodies; the sole review (sourcery-ai[bot]) is a bare approval.
Root-Cause Investigation N/A No sub-tasks created.
Scope Containment PASS Only fullsend.md changed — matches the task's sole expected file.
Diff Size PASS +167/-6 across 1 file; proportionate for a documentation expansion.
Commit Traceability PASS Single commit references TC-6193 (Implements TC-6193).
Sensitive Patterns PASS No secret values in added lines; only variable names/purposes and non-secret resource identifiers.
CI Status WARN Only failing/pending checks are verify-pr's own self-referential harness runs; all substantive checks (plugin validation, script unit tests, skill lint, sourcery) pass.
Acceptance Criteria PASS 4 of 4 criteria met.
Test Quality N/A No test files in the diff; Eval Quality: N/A (no eval result reviews).
Test Change Classification N/A No test files changed.
Verification Commands N/A No commands specified; no eval-infrastructure changes in the diff.

Overall: WARN

This documentation-only PR expands fullsend.md to cover CI install (github setup, inference provision, org GitHub App), the inline-wait dispatch design (CEL trigger + pre_script Jira gating), and the version-bump / plugin-version-sync upgrade procedures — satisfying all four acceptance criteria. Scope, diff size, commit traceability, and the secret scan all pass. The Overall: WARN is driven solely by CI Status: the only non-passing checks are the verify-pr harness's own self-referential runs (a prior attempt reported failure and the current run is in_progress); every substantive validation check passes. No code change requests, CI-failure defects, or eval regressions were found, so no sub-tasks were created. Merge remains a human decision.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.9.

@mrizzi
mrizzi merged commit 2b0785a into verify-pr-fullsend Sep 17, 2026
52 of 53 checks passed
@mrizzi
mrizzi deleted the TC-6193 branch September 17, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant